mirror of
https://github.com/LMMS/lmms.git
synced 2026-02-02 02:33:25 -05:00
17c919879f
* Initial Commit Starts implementing Note Types. The two available types are RegularNote and StepNote. PianoRoll now paints the color with a different color for StepNotes. Pattern::addStep now sets the type of the note to StepNote. Negative size is still used to signal a step note. * Update Pattern.cpp to account for the Note::Type Updates the methods noteAtStep(), addStepNote() and checkType() from Pattern.cpp to account for the note type and not the note length. * Update PatternView::paintEvent to draw step notes PatternView::paintEvent now draws the pattern if the pattern type is BeatPattern and TCOs aren't fixed (Song Editor). Color used is still the BeatPattern color (grey) and the conditional doesn't look very nice and can be improved. Pattern::beatPatternLength was also updated so it accounts for the note type not note length. Review this method, as it looks a bit weird (particularly the second conditional). * Implements StepNotes setting a NPH with 0 frames Now, instead of TimePos returning 0 for negative lengths, we create a NotePlayHandle with 0 frames when the note type is StepNote on InstrumentTrack::play. * Improves PatternView::paintEvent conditional Improves a conditional inside PatternView::paintEvent by reversing the order in which they are executed. * Adds upgrade method for backwards compatibility Adds an upgrade method that converts notes with negative length to StepNotes, so old projects can be loaded properly. Explicitly set the Note::RegularNote value as 0. Make the default "type" value "0", so notes without a type are loaded as RegularNotes. * Addresses Veratil's review - Changes "addStepNote" so "checkType" isn't called twice in a row. - Changes style on a one line conditional. * Uses ternary expression on statement Reduces number of lines by using ternary expression. * Addresses PR review (sakertooth) - Changes class setter to inline - Uses enum class instead of enum - Uses auto and const where appropriate * Finished changes from review (sakertooth) - Used std::max instead of qMax - Fixed style on lines changed in the PR * Uses std::find_if to save codelines As suggested by sakertooth, by using std::find_if we are able to simplify the checkType method to two lines. * Addresses review from sakertooth - Reverts m_detuning in-class initialization - Removes testing warning - Removes unnecessary comment * Addresses DomClark's review - Rename the Note Types enum to avoid redundancy - Uses std::all_of instead of std::find_if on MidiClip checkType - Rewrites addStepNote so it sets the note type before adding it to the clip, avoiding having to manually change the type of the clip after adding the note * Updates MidiExport to use Note Types - Now MidiExport is updated to use note types instead of relying on negative length notes. - For that change it was necessary to find a way of letting MidiExport know how long step notes should be. The solution found was to add an attribute to the Instrument XML called "beatlen", which would hold the number of frames of the instrument's beat. That would be converted to ticks, so we could calculate how long the MIDI notes would have to be to play the whole step note. If the attribute was not found, the default value of 16 ticks would be used as a length of step notes, as a fallback. * Fixes ambiguity on enum usage Due to changes in the name of enum classes, there was an ambiguity caused in NotePlayHandle.cpp. That was fixed. * Addresses new code reviews - Addresses code review from PhysSong and Messmerd * Fixes note drawing on Song Editor - Notes were not being draw on the song editor for BeatClips. This commit fixes this. * Adds cassert header to TimePos.cpp - Adds header to use assert() on TimePos.cpp * Apply suggestions from code review Fixes style on some lines Co-authored-by: Dalton Messmer <33463986+messmerd@users.noreply.github.com> * Reverts some changes on MidiExport - Some changes were reverted on MidiExport and InstrumentTrack. We were storing the beat length on the XML of Instrument Tracks, but in reality the beat length is a per note attribute, and some instruments could run into a segmentation fault when calling beat length without a NotePlayHandle (i.e.: AFP). Because of that I reverted this change, so the beat length is not stored on the XML anymore, and instead we have a magic number on the MidiExport class that holds a default beat length which is actually an upper limit for the MIDI notes of step notes. In the future we can improve this by finding a way to store the beat length on the note class to use it instead. The MidiExport logic is not worsened at all because previously the beat length wasn't even considered during export (it was actually improved making the exported notes extend until the next one instead of cutting shorter). * Fix the order of included files --------- Co-authored-by: Dalton Messmer <33463986+messmerd@users.noreply.github.com>
159 lines
3.9 KiB
C++
159 lines
3.9 KiB
C++
/*
|
|
* DataFile.h - class for reading and writing LMMS data files
|
|
*
|
|
* Copyright (c) 2004-2014 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
* Copyright (c) 2012-2013 Paul Giblock <p/at/pgiblock.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_DATA_FILE_H
|
|
#define LMMS_DATA_FILE_H
|
|
|
|
#include <map>
|
|
#include <QDomDocument>
|
|
|
|
#include "lmms_export.h"
|
|
#include "MemoryManager.h"
|
|
|
|
class QTextStream;
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
class ProjectVersion;
|
|
|
|
|
|
class LMMS_EXPORT DataFile : public QDomDocument
|
|
{
|
|
MM_OPERATORS
|
|
|
|
using UpgradeMethod = void(DataFile::*)();
|
|
|
|
public:
|
|
enum class Type
|
|
{
|
|
Unknown,
|
|
SongProject,
|
|
SongProjectTemplate,
|
|
InstrumentTrackSettings,
|
|
DragNDropData,
|
|
ClipboardData,
|
|
JournalData,
|
|
EffectSettings,
|
|
MidiClip
|
|
} ;
|
|
|
|
DataFile( const QString& fileName );
|
|
DataFile( const QByteArray& data );
|
|
DataFile( Type type );
|
|
|
|
virtual ~DataFile() = default;
|
|
|
|
///
|
|
/// \brief validate
|
|
/// performs basic validation, compared to file extension.
|
|
///
|
|
bool validate( QString extension );
|
|
|
|
QString nameWithExtension( const QString& fn ) const;
|
|
|
|
void write( QTextStream& strm );
|
|
bool writeFile(const QString& fn, bool withResources = false);
|
|
bool copyResources(const QString& resourcesDir); //!< Copies resources to the resourcesDir and changes the DataFile to use local paths to them
|
|
bool hasLocalPlugins(QDomElement parent = QDomElement(), bool firstCall = true) const;
|
|
|
|
QDomElement& content()
|
|
{
|
|
return m_content;
|
|
}
|
|
|
|
QDomElement& head()
|
|
{
|
|
return m_head;
|
|
}
|
|
|
|
Type type() const
|
|
{
|
|
return m_type;
|
|
}
|
|
|
|
unsigned int legacyFileVersion();
|
|
|
|
private:
|
|
static Type type( const QString& typeName );
|
|
static QString typeName( Type type );
|
|
|
|
void cleanMetaNodes( QDomElement de );
|
|
|
|
// helper upgrade routines
|
|
void upgrade_0_2_1_20070501();
|
|
void upgrade_0_2_1_20070508();
|
|
void upgrade_0_3_0_rc2();
|
|
void upgrade_0_3_0();
|
|
void upgrade_0_4_0_20080104();
|
|
void upgrade_0_4_0_20080118();
|
|
void upgrade_0_4_0_20080129();
|
|
void upgrade_0_4_0_20080409();
|
|
void upgrade_0_4_0_20080607();
|
|
void upgrade_0_4_0_20080622();
|
|
void upgrade_0_4_0_beta1();
|
|
void upgrade_0_4_0_rc2();
|
|
void upgrade_1_0_99();
|
|
void upgrade_1_1_0();
|
|
void upgrade_1_1_91();
|
|
void upgrade_1_2_0_rc3();
|
|
void upgrade_1_3_0();
|
|
void upgrade_noHiddenClipNames();
|
|
void upgrade_automationNodes();
|
|
void upgrade_extendedNoteRange();
|
|
void upgrade_defaultTripleOscillatorHQ();
|
|
void upgrade_mixerRename();
|
|
void upgrade_bbTcoRename();
|
|
void upgrade_sampleAndHold();
|
|
void upgrade_midiCCIndexing();
|
|
void upgrade_loopsRename();
|
|
void upgrade_noteTypes();
|
|
|
|
// List of all upgrade methods
|
|
static const std::vector<UpgradeMethod> UPGRADE_METHODS;
|
|
// List of ProjectVersions for the legacyFileVersion method
|
|
static const std::vector<ProjectVersion> UPGRADE_VERSIONS;
|
|
|
|
// Map with DOM elements that access resources (for making bundles)
|
|
using ResourcesMap = std::map<QString, std::vector<QString>>;
|
|
static const ResourcesMap ELEMENTS_WITH_RESOURCES;
|
|
|
|
void upgrade();
|
|
|
|
void loadData( const QByteArray & _data, const QString & _sourceFile );
|
|
|
|
QString m_fileName; //!< The origin file name or "" if this DataFile didn't originate from a file
|
|
QDomElement m_content;
|
|
QDomElement m_head;
|
|
Type m_type;
|
|
unsigned int m_fileVersion;
|
|
|
|
} ;
|
|
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_DATA_FILE_H
|