DigArtRoks
5f4d0cab9b
Fix for issue #3816 - FM or heavy PM in TripleOscillator makes outputs odd for some target waveforms. ( #5651 )
...
The internal waveforms of the class Oscillator produces the wrong amplitude when the input is a
negative phase. When doing PM or FM, negative phases may occur. When a negative phase is e.g. passed
to the the saw sample, it produces values less than -1.0, hence going out of range.
Converted all fraction calls to absFraction calls.
Removed the +2 in the function Oscillator::recalcPhase. The comment here was that it was needed to avoid
negative phases in case of PM. But by converting fraction to absFraction in the waveforms, negative phases
are not an issue anymore. On top of that the m_phase variable gains about 2 extra bits in precision.
As side effect of that, it improves the behaviour of the issue #2047 - TripleOscillator: Oscillators are getting out of sync.
Though I did not investigate it thoroughly over different notes and samplerates.
Add documentation to the fraction and absFraction functions in lmms_math.h as it was not immediately clear by the name what the
functions do. Correct the implementation of the functions in case the flag __INTEL_COMPILER is set. (floorf rounds always down).
2020-09-10 22:47:06 +02:00
..
2017-02-06 02:41:15 +02:00
2017-02-06 02:41:15 +02:00
2020-05-17 11:15:39 +09:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-07-10 10:58:52 +09:00
2017-02-06 02:41:15 +02:00
2020-08-30 19:27:17 +01:00
2018-07-05 20:16:01 +09:00
2017-08-04 07:19:39 +09:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2020-08-30 19:27:17 +01:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-06-09 20:45:45 -04:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-08-11 10:18:34 -05:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-07-07 11:20:54 +02:00
2017-02-06 02:41:15 +02:00
2019-06-15 23:33:29 +03:00
2020-06-13 12:14:47 -03:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2017-02-06 02:41:15 +02:00
2020-08-11 11:01:58 +02:00
2020-08-17 10:12:49 -04:00
2019-03-16 20:19:27 +01:00
2020-07-20 11:39:53 +09:00
2020-05-17 09:22:36 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-04-24 11:25:49 +03:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-02-21 19:26:29 +01:00
2019-10-31 20:05:33 +01:00
2020-05-17 11:15:39 +09:00
2018-09-18 09:54:38 +09:00
2017-12-11 10:46:19 -05:00
2017-02-06 02:41:15 +02:00
2015-04-27 13:04:26 +03:00
2019-10-31 20:05:33 +01:00
2018-07-05 20:16:01 +09:00
2019-06-15 23:33:29 +03:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-07-24 10:33:15 +09:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2018-10-11 19:32:11 +02:00
2017-02-06 02:41:15 +02:00
2020-05-24 12:50:50 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-04-29 20:44:09 +02:00
2019-10-31 20:05:33 +01:00
2018-03-09 11:41:17 -05:00
2020-03-11 15:07:02 -04:00
2018-07-10 11:13:56 +09:00
2020-04-19 22:08:09 +02:00
2018-07-07 11:20:54 +02:00
2020-08-11 11:01:58 +02:00
2019-10-31 20:05:33 +01:00
2020-08-11 11:01:58 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2018-07-07 11:20:54 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-05-19 11:34:54 +09:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-08-30 19:27:17 +01:00
2019-10-31 20:05:33 +01:00
2020-06-21 11:17:05 +09:00
2019-07-17 22:20:25 +02:00
2017-02-06 02:41:15 +02:00
2018-07-05 20:16:01 +09:00
2019-10-31 20:05:33 +01:00
2020-06-01 15:19:20 +02:00
2018-12-27 21:24:19 +01:00
2008-07-22 11:36:50 +00:00
2018-04-15 21:38:37 -04:00
2019-10-31 20:05:33 +01:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2020-06-01 15:19:20 +02:00
2020-04-04 12:08:55 +09:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2020-02-21 19:26:29 +01:00
2020-05-17 09:22:36 +02:00
2020-06-09 20:45:45 -04:00
2019-11-21 14:44:18 +01:00
2020-09-10 22:47:06 +02:00
2019-09-09 00:22:43 -04:00
2019-10-31 20:05:33 +01:00
2018-09-12 11:02:40 +09:00
2018-04-28 12:54:46 -07:00
2018-04-28 12:54:46 -07:00
2020-01-05 17:54:29 +01:00
2020-05-24 12:50:50 +02:00
2020-05-24 12:50:50 +02:00
2020-08-09 22:59:37 +02:00
2020-08-09 22:59:37 +02:00
2020-05-24 12:50:50 +02:00
2020-08-09 22:59:37 +02:00
2020-05-24 12:50:50 +02:00
2020-08-09 22:59:37 +02:00
2020-05-24 12:50:50 +02:00
2019-10-31 20:05:33 +01:00
2020-07-11 11:30:27 +02:00
2017-09-26 20:33:09 +02:00
2018-07-07 11:20:54 +02:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2017-11-22 20:38:10 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-06-17 14:27:28 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2017-02-06 02:41:15 +02:00
2017-11-17 09:51:56 -05:00
2019-10-31 20:05:33 +01:00
2020-06-02 10:48:34 +09:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 15:13:25 +01:00
2018-06-17 14:27:28 +02:00
2019-10-31 20:05:33 +01:00
2017-11-22 20:38:10 +01:00
2019-10-31 20:05:33 +01:00
2019-01-31 23:12:45 +01:00
2019-03-27 07:05:38 +09:00
2018-07-07 11:20:54 +02:00
2019-04-27 15:26:17 +02:00
2019-10-31 20:05:33 +01:00
2020-05-19 11:34:54 +09:00
2019-10-31 20:05:33 +01:00
2020-09-10 22:47:06 +02:00
2020-07-11 18:40:12 -04:00
2017-08-04 07:19:39 +09:00
2017-02-06 02:41:15 +02:00
2019-11-15 17:09:57 -05:00
2020-07-28 17:07:35 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-04-03 13:37:25 +02:00
2018-05-06 16:34:08 -07:00
2020-08-09 18:01:35 -05:00
2020-06-21 11:17:05 +09:00
2019-11-15 17:09:57 -05:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-04-03 00:35:33 +02:00
2018-12-27 21:24:19 +01:00
2019-04-17 19:08:59 +02:00
2018-07-07 11:20:54 +02:00
2020-08-09 18:01:35 -05:00
2019-10-31 20:05:33 +01:00
2019-05-13 20:23:01 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2019-08-24 18:55:30 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-04-25 18:49:39 +02:00
2019-11-21 14:44:18 +01:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-07-28 17:07:35 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2020-04-29 20:44:09 +02:00
2019-10-31 20:05:33 +01:00
2018-07-07 11:20:54 +02:00
2020-08-01 20:03:23 +02:00
2018-04-25 12:50:44 +02:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2020-06-04 14:21:30 +09:00
2020-08-09 18:01:35 -05:00
2020-04-04 12:13:01 +09:00
2019-02-09 22:45:27 +01:00
2020-08-09 18:01:35 -05:00
2018-07-07 11:20:54 +02:00
2019-10-31 20:05:33 +01:00
2017-02-06 02:41:15 +02:00
2018-07-07 11:20:54 +02:00
2017-02-06 02:41:15 +02:00
2019-10-31 20:05:33 +01:00
2019-08-28 22:51:54 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-04-28 12:54:46 -07:00
2019-10-31 20:05:33 +01:00
2020-08-09 18:01:35 -05:00
2018-05-06 16:34:08 -07:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2018-07-07 11:20:54 +02:00
2020-08-10 17:16:00 +02:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2019-10-31 20:05:33 +01:00
2018-07-07 11:20:54 +02:00
2019-06-09 15:44:32 +03:00
2019-10-21 11:18:39 +09:00
2019-11-06 22:06:15 -05:00
2019-03-14 09:44:48 +09:00
2019-03-14 09:44:48 +09:00