mirror of
https://github.com/LMMS/lmms.git
synced 2026-04-10 00:58:36 -04:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
80 lines
2.4 KiB
C++
80 lines
2.4 KiB
C++
/*
|
|
* VecControlsDialog.cpp - definition of VecControlsDialog class.
|
|
*
|
|
* Copyright (c) 2019 Martin Pavelek <he29/dot/HS/at/gmail/dot/com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#include "VecControlsDialog.h"
|
|
|
|
|
|
#include <QHBoxLayout>
|
|
#include <QVBoxLayout>
|
|
|
|
#include "LedCheckBox.h"
|
|
#include "VecControls.h"
|
|
#include "Vectorscope.h"
|
|
#include "VectorView.h"
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
|
|
// The entire GUI layout is built here.
|
|
VecControlsDialog::VecControlsDialog(VecControls *controls) :
|
|
EffectControlDialog(controls),
|
|
m_controls(controls)
|
|
{
|
|
auto master_layout = new QVBoxLayout;
|
|
master_layout->setContentsMargins(0, 0, 0, 0);
|
|
setLayout(master_layout);
|
|
|
|
// Visualizer widget
|
|
auto display = new VectorView(controls, m_controls->m_effect->getBuffer(), this);
|
|
master_layout->addWidget(display);
|
|
|
|
auto controlLayout = new QHBoxLayout();
|
|
master_layout->addLayout(controlLayout);
|
|
|
|
// Log. scale switch
|
|
auto logarithmicButton = new LedCheckBox(tr("Log. scale"), this);
|
|
logarithmicButton->setToolTip(tr("Display amplitude on logarithmic scale to better see small values."));
|
|
logarithmicButton->setCheckable(true);
|
|
logarithmicButton->setModel(&controls->m_logarithmicModel);
|
|
controlLayout->addWidget(logarithmicButton);
|
|
|
|
controlLayout->addStretch();
|
|
|
|
// Switch between lines mode and point mode
|
|
auto linesMode = new LedCheckBox(tr("Lines"), this);
|
|
linesMode->setToolTip(tr("Render with lines."));
|
|
linesMode->setCheckable(true);
|
|
linesMode->setModel(&controls->m_linesModeModel);
|
|
controlLayout->addWidget(linesMode);
|
|
}
|
|
|
|
|
|
// Suggest the best widget size.
|
|
QSize VecControlsDialog::sizeHint() const
|
|
{
|
|
return QSize(275, 300);
|
|
}
|
|
|
|
} // namespace lmms::gui
|