mirror of
https://github.com/LMMS/lmms.git
synced 2026-01-23 13:58:17 -05:00
3c7bfbac64
This prevents a race condition with Qt5. A foreach loop makes a copy of its Qt container, increasing the reference count to the container's internal data. Qt5 often asserts isDetached(), which requires the reference count to be <= 1. This assertion fails when the foreach loop increases the reference count at exactly the wrong moment. Using a range-based for loop prevents an unnecessary copy from being made and ensures this race condition isn't triggered.
91 lines
2.3 KiB
C++
91 lines
2.3 KiB
C++
/*
|
|
* InstrumentPlayHandle.h - play-handle for driving an instrument
|
|
*
|
|
* Copyright (c) 2005-2014 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - http://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef INSTRUMENT_PLAY_HANDLE_H
|
|
#define INSTRUMENT_PLAY_HANDLE_H
|
|
|
|
#include "PlayHandle.h"
|
|
#include "Instrument.h"
|
|
#include "NotePlayHandle.h"
|
|
#include "export.h"
|
|
|
|
class EXPORT InstrumentPlayHandle : public PlayHandle
|
|
{
|
|
public:
|
|
InstrumentPlayHandle( Instrument * instrument, InstrumentTrack* instrumentTrack );
|
|
|
|
virtual ~InstrumentPlayHandle()
|
|
{
|
|
}
|
|
|
|
|
|
virtual void play( sampleFrame * _working_buffer )
|
|
{
|
|
// if the instrument is midi-based, we can safely render right away
|
|
if( m_instrument->flags() & Instrument::IsMidiBased )
|
|
{
|
|
m_instrument->play( _working_buffer );
|
|
return;
|
|
}
|
|
|
|
// if not, we need to ensure that all our nph's have been processed first
|
|
ConstNotePlayHandleList nphv = NotePlayHandle::nphsOfInstrumentTrack( m_instrument->instrumentTrack(), true );
|
|
|
|
bool nphsLeft;
|
|
do
|
|
{
|
|
nphsLeft = false;
|
|
for( const NotePlayHandle * constNotePlayHandle : nphv )
|
|
{
|
|
NotePlayHandle * notePlayHandle = const_cast<NotePlayHandle *>( constNotePlayHandle );
|
|
if( notePlayHandle->state() != ThreadableJob::Done && ! notePlayHandle->isFinished() )
|
|
{
|
|
nphsLeft = true;
|
|
notePlayHandle->process();
|
|
}
|
|
}
|
|
}
|
|
while( nphsLeft );
|
|
|
|
m_instrument->play( _working_buffer );
|
|
}
|
|
|
|
virtual bool isFinished() const
|
|
{
|
|
return false;
|
|
}
|
|
|
|
virtual bool isFromTrack( const Track* _track ) const
|
|
{
|
|
return m_instrument->isFromTrack( _track );
|
|
}
|
|
|
|
|
|
private:
|
|
Instrument* m_instrument;
|
|
|
|
} ;
|
|
|
|
#endif
|