Michael Gregorius
d3d710e0ad
Remove identical calls to InstrumentTrack::processAudioBuffer
...
Remove identical calls to `InstrumentTrack::processAudioBuffer` which appear in the overridden implementations of `Instrument::play` and `Instrument::playNotes`. Instead the call to `processAudioBuffer` has been moved into `InstrumentPlayHandle::play` and `InstrumentTrack::playNote`. These two methods call the aforementioned methods of `Instrument`. Especially in the case of `InstrumentTrack::playNote` the previous implementation resulted in some unncessary "ping pong" where `InstrumentTrack` called a method on an `Instrument` which then in turn called a method on `InstrumentTrack`. And this was done in almost every instrument.
In `InstrumentTrack::playNote` an additional check was added which only calls `processAudioBuffer` if the buffer is not `nullptr`. The reason is that under certain circumstances `PlayHandle::doProcessing` calls the `play` method by explicitly passing a `nullptr` as the buffer. This behavior was added with commit 7bc97f5d5b . Because it is unknown if this was done for some side effects the code was adjusted so that it behaves identical in this case.
Move the complex implementation for `InstrumentPlayHandle::play` and `InstrumentPlayHandle::isFromTrack` into the cpp file and optimize the includes.
2023-09-14 23:12:22 +02:00
..
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-07 21:12:23 -05:00
2023-08-31 07:12:00 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-09-04 19:33:42 -04:00
2023-09-04 19:33:42 -04:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 17:28:34 +01:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-09-04 19:33:42 -04:00
2023-08-24 19:16:02 +01:00
2023-09-12 20:35:54 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 17:28:34 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-07 21:12:23 -05:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-02-18 09:32:27 -06:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-04-29 16:53:58 +02:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-09-10 11:52:18 -04:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-09-14 23:12:22 +02:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-31 19:21:26 +02:00
2023-08-28 13:14:19 -04:00
2023-08-31 19:21:26 +02:00
2023-08-31 19:21:26 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-02-18 09:32:27 -06:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-29 15:32:11 -04:00
2023-01-05 17:58:49 -05:00
2008-07-22 11:36:50 +00:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-09-12 20:35:54 +02:00
2023-02-21 21:03:00 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 17:28:34 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-02-21 21:03:00 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-02-21 21:03:00 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-02-21 21:03:00 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-08-31 12:55:02 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-05-10 20:14:24 +09:00
2023-01-05 17:58:49 -05:00
2023-06-02 22:17:03 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-31 17:17:00 +02:00
2023-08-31 17:17:00 +02:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-31 12:55:02 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-05-06 13:16:07 +09:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-25 14:43:09 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-28 13:14:19 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-29 15:32:11 -04:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-04-29 16:53:58 +02:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-28 13:14:19 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-02 23:05:27 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00