Michael Gregorius
d447cb0648
Use layouts for the instrument sound shaping tab / Extract classes for Envelope and LFO graphs ( #7193 )
...
Move the envelope and LFO graphs into their own classes.
Besides the improved code organization this step had to be done to be able to use layouts in `EnvelopeAndLfoView`. The class previously had fixed layouts mixed with custom rendering in the paint event. Mouse events are now also handled in both new classes instead of in `EnvelopeAndLfoView`.
## Layouts in EnvelopeAndLfoView
Use layouts to align the elements of the `EnvelopeAndLfoView`. This removes lots of hard-coded values. Add helper lambdas for the repeated creation of `Knob` and `PixmapButton` instances.
The spacing that is explicitly introduced between the envelope and LFO should be removed once there is a more open layout.
## Layouts for InstrumentSoundShapingView
Use layouts to align the elements of the `InstrumentSoundShapingView`.
## Info text improvements in LFO graph
Draw the info text at around 20% of the LFO graph's height. This prepares the dialog to be scaled later.
Write "1000 ms/LFO" instead of "ms/LFO: 1000" with a larger gap.
## Accessors for EnvelopeAndLfoParameters
Make the enum `LfoShape` in `EnvelopeAndLfoParameters` public so that it can be used without friend declarations. Add accessor methods for the model of the LFO.
## Other improvements
* Adjust include orders
* Variable initialization in headers
* Prevention of most vexing parses
2024-04-05 11:25:39 +02:00
..
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-07 21:12:23 -05:00
2023-08-31 07:12:00 -04:00
2023-01-05 17:58:49 -05:00
2023-07-25 18:03:18 +02:00
2024-03-10 23:06:46 -04:00
2023-07-25 18:03:18 +02:00
2023-07-25 18:03:18 +02:00
2023-11-18 15:28:01 -05:00
2023-09-04 19:33:42 -04:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2024-03-10 23:06:46 -04:00
2024-03-10 23:06:46 -04:00
2024-03-10 23:06:46 -04:00
2024-03-10 23:06:46 -04:00
2023-10-31 23:45:02 +01:00
2023-07-25 18:03:18 +02:00
2024-02-25 13:49:56 -05:00
2023-07-25 18:03:18 +02:00
2023-07-25 18:03:18 +02:00
2023-12-25 07:07:11 -05:00
2024-03-10 23:06:46 -04:00
2023-07-25 18:03:18 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-03-16 14:34:01 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-10-06 18:37:46 -04:00
2023-11-19 00:44:15 -05:00
2023-11-25 12:16:56 +01:00
2023-10-06 18:37:46 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-10-29 11:16:39 +01:00
2023-01-05 17:58:49 -05:00
2024-03-28 17:21:31 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-02-25 13:49:56 -05:00
2023-11-11 18:09:38 -05:00
2023-11-19 14:52:37 +00:00
2023-01-05 17:58:49 -05:00
2023-11-19 00:44:15 -05:00
2023-08-24 17:28:34 +01:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-10-21 18:21:21 +02:00
2023-08-24 19:16:02 +01:00
2024-02-25 13:49:56 -05:00
2023-01-05 17:58:49 -05:00
2024-02-25 13:49:56 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-02-25 13:49:56 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 17:28:34 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-07 21:12:23 -05:00
2024-02-25 13:49:56 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-03-16 14:34:01 +09:00
2023-02-18 09:32:27 -06:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-04-05 11:25:39 +02:00
2024-04-05 11:25:39 +02:00
2024-04-05 11:25:39 +02:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-12-31 21:52:56 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-11-23 20:31:49 -05:00
2023-11-18 20:47:15 -05:00
2023-01-05 17:58:49 -05:00
2023-09-28 20:23:35 -04:00
2023-10-29 11:16:39 +01:00
2023-08-24 19:16:02 +01:00
2024-02-10 14:27:50 +01:00
2024-04-04 21:40:31 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-02-25 13:49:56 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-09-16 13:35:15 +02:00
2023-08-24 19:16:02 +01:00
2024-04-05 11:25:39 +02:00
2024-02-25 13:49:56 -05:00
2024-03-13 20:00:58 +01:00
2023-12-30 17:55:28 +01:00
2023-08-31 19:21:26 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-03-28 17:21:31 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-10-29 11:16:39 +01:00
2023-01-05 17:58:49 -05:00
2008-07-22 11:36:50 +00:00
2024-03-16 14:34:01 +09:00
2023-10-29 11:16:39 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-10-07 21:01:30 -07:00
2023-01-05 17:58:49 -05:00
2023-11-19 00:44:15 -05:00
2023-11-19 00:44:15 -05:00
2023-01-05 17:58:49 -05:00
2023-12-25 07:07:11 -05:00
2024-04-05 11:25:39 +02:00
2023-02-21 21:03:00 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2024-01-15 17:19:33 -05:00
2023-01-05 17:58:49 -05:00
2023-09-24 17:36:59 +02:00
2023-08-24 19:16:02 +01:00
2024-03-28 17:21:31 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-09-24 17:36:59 +02:00
2023-09-24 17:36:59 +02:00
2024-02-18 15:56:45 +01:00
2023-01-05 17:58:49 -05:00
2023-09-24 17:36:59 +02:00
2023-09-24 17:36:59 +02:00
2023-11-12 02:20:53 +01:00
2023-08-24 19:16:02 +01:00
2024-02-18 15:56:45 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-09-28 20:23:35 -04:00
2023-11-12 02:25:26 +01:00
2023-10-27 18:51:00 -04:00
2023-01-05 17:58:49 -05:00
2023-12-16 14:19:36 +00:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2024-02-23 15:57:41 -05:00
2023-11-25 12:16:56 +01:00
2023-09-22 20:07:25 +01:00
2023-01-05 17:58:49 -05:00
2023-09-28 20:23:35 -04:00
2024-02-25 13:49:56 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-07-22 23:03:31 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-11-19 14:52:37 +00:00
2023-12-30 17:55:28 +01:00
2024-03-25 19:22:37 -04:00
2024-03-25 19:22:37 -04:00
2024-03-10 23:06:46 -04:00
2023-06-02 22:17:03 +02:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-11-12 02:20:53 +01:00
2023-11-18 17:14:27 -05:00
2024-02-25 13:49:56 -05:00
2023-12-16 14:19:36 +00:00
2023-12-25 07:07:11 -05:00
2023-01-05 17:58:49 -05:00
2024-03-26 20:19:52 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-11-19 00:44:15 -05:00
2023-11-19 00:44:15 -05:00
2023-01-05 17:58:49 -05:00
2024-01-08 09:44:58 -05:00
2023-08-24 19:16:02 +01:00
2024-02-25 13:49:56 -05:00
2023-05-06 13:16:07 +09:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2024-02-25 13:49:56 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-02-16 16:31:44 -05:00
2024-02-16 16:31:44 -05:00
2023-12-25 07:07:11 -05:00
2023-11-25 12:16:56 +01:00
2023-12-25 07:07:11 -05:00
2023-12-25 07:07:11 -05:00
2023-12-25 07:07:11 -05:00
2023-12-25 07:07:11 -05:00
2023-01-05 17:58:49 -05:00
2023-12-30 17:55:28 +01:00
2023-12-30 17:55:28 +01:00
2024-01-13 21:05:18 -05:00
2023-01-05 17:58:49 -05:00
2023-12-30 17:55:28 +01:00
2023-01-05 17:58:49 -05:00
2023-12-25 16:26:35 +00:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-08-29 15:32:11 -04:00
2023-12-16 14:19:36 +00:00
2023-08-24 19:16:02 +01:00
2023-08-22 12:08:56 +09:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-11-12 02:21:51 +01:00
2023-01-05 17:58:49 -05:00
2023-07-16 14:11:24 +02:00
2023-01-05 17:58:49 -05:00
2023-12-31 11:55:59 +01:00
2023-01-05 17:58:49 -05:00
2023-10-29 11:16:39 +01:00
2023-08-24 19:16:02 +01:00
2023-10-29 11:16:39 +01:00
2023-04-29 16:53:58 +02:00
2023-01-05 17:58:49 -05:00
2023-08-24 19:16:02 +01:00
2023-12-16 14:19:36 +00:00
2023-12-25 16:26:35 +00:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-02-25 13:49:56 -05:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2023-08-24 19:16:02 +01:00
2024-03-13 20:00:58 +01:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2024-02-18 21:22:22 +01:00
2024-02-25 13:49:56 -05:00
2023-01-05 17:58:49 -05:00
2023-08-02 23:05:27 -04:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00
2023-01-05 17:58:49 -05:00