mirror of
https://github.com/LMMS/lmms.git
synced 2026-05-17 03:07:17 -04:00
34ab5ff730
On plugin instantiation failure, `Lv2Proc::m_valid` was being set to false. However, `Lv2Proc::run` did not evaluate `m_valid` and still called `lilv_instance_run`, which caused undefined behavior, including crashes. This bug fixes this by not even create such zombie classes, and instead `throw`s right away. The throws are caught in `lmms_plugin_main`, as suggested in the PR discussion and as the VST3 approach.
60 lines
1.5 KiB
C++
60 lines
1.5 KiB
C++
/*
|
|
* Lv2Effect.h - implementation of LV2 effect
|
|
*
|
|
* Copyright (c) 2018-2023 Johannes Lorenz <jlsf2013$users.sourceforge.net, $=@>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LV2_EFFECT_H
|
|
#define LV2_EFFECT_H
|
|
|
|
#include "Effect.h"
|
|
#include "Lv2FxControls.h"
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
|
|
class Lv2Effect : public Effect
|
|
{
|
|
Q_OBJECT
|
|
|
|
public:
|
|
/*
|
|
initialization
|
|
*/
|
|
Lv2Effect(Model* parent, const Descriptor::SubPluginFeatures::Key* _key);
|
|
|
|
bool processAudioBuffer( sampleFrame* buf, const fpp_t frames ) override;
|
|
EffectControls* controls() override { return &m_controls; }
|
|
|
|
Lv2FxControls* lv2Controls() { return &m_controls; }
|
|
const Lv2FxControls* lv2Controls() const { return &m_controls; }
|
|
|
|
private:
|
|
Lv2FxControls m_controls;
|
|
std::vector<sampleFrame> m_tmpOutputSmps;
|
|
};
|
|
|
|
|
|
} // namespace lmms
|
|
|
|
#endif
|