mirror of
https://github.com/LMMS/lmms.git
synced 2026-01-27 15:58:11 -05:00
a2cb7e96ea
Fixes bugs where during project loading (observed with VST effects), empty widgets and sub-windows would be left floating around. These were caused by inconsistencies between the way VST UIs were created when loading a project and when adding an effect in an existing project. In some situations, this caused createUI to be called twice, leaving over multiple empty widgets. This commit refactors some code in order to avoid creating unnecessary sub- windows, which aren't needed with VST effects, but were still created, usually being invisible. All sub-window related code was moved out of VstPlugin into vestige.cpp, which is the only place where sub-window VSTs are actually used. A new sub-class of VstPlugin, VstInstrumentPlugin, now handles VST sub-windows and is used by vestigeInstrument. "guivisible" attribute loading was moved out of VstPlugin as well and is now done in VstEffectControls' and vestigeInstrument's loadSettings method respectively. This causes some minor code duplication unfortunately. Closes #4110
138 lines
2.8 KiB
C++
138 lines
2.8 KiB
C++
/*
|
|
* VstEffectControls.h - controls for VST effect plugins
|
|
*
|
|
* Copyright (c) 2008-2011 Tobias Doerffel <tobydox/at/users.sourceforge.net>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef _VST_EFFECT_CONTROLS_H
|
|
#define _VST_EFFECT_CONTROLS_H
|
|
|
|
#include "EffectControls.h"
|
|
#include "VstEffectControlDialog.h"
|
|
|
|
#include <QMenu>
|
|
#include "embed.h"
|
|
#include <QPushButton>
|
|
|
|
#include <QMdiSubWindow>
|
|
#include <QScrollArea>
|
|
#include "Knob.h"
|
|
#include <QLayout>
|
|
#include <QPainter>
|
|
#include <QObject>
|
|
|
|
|
|
class VstEffect;
|
|
|
|
|
|
class VstEffectControls : public EffectControls
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
VstEffectControls( VstEffect * _eff );
|
|
virtual ~VstEffectControls();
|
|
|
|
virtual void saveSettings( QDomDocument & _doc, QDomElement & _parent );
|
|
virtual void loadSettings( const QDomElement & _this );
|
|
inline virtual QString nodeName() const
|
|
{
|
|
return "vsteffectcontrols";
|
|
}
|
|
|
|
virtual int controlCount();
|
|
|
|
virtual EffectControlDialog * createView();
|
|
|
|
|
|
protected slots:
|
|
void updateMenu( void );
|
|
void managePlugin( void );
|
|
void openPreset( void );
|
|
void savePreset( void );
|
|
void rollPreset( void );
|
|
void rolrPreset( void );
|
|
void selPreset( void );
|
|
void setParameter( void );
|
|
|
|
protected:
|
|
virtual void paintEvent( QPaintEvent * _pe );
|
|
|
|
private:
|
|
VstEffect * m_effect;
|
|
|
|
QPushButton * m_selPresetButton;
|
|
|
|
QMdiSubWindow * m_subWindow;
|
|
QScrollArea * m_scrollArea;
|
|
FloatModel ** knobFModel;
|
|
int paramCount;
|
|
|
|
QObject * ctrHandle;
|
|
|
|
int lastPosInMenu;
|
|
// QLabel * m_presetLabel;
|
|
|
|
friend class VstEffectControlDialog;
|
|
friend class manageVSTEffectView;
|
|
|
|
bool m_vstGuiVisible;
|
|
} ;
|
|
|
|
|
|
|
|
|
|
class manageVSTEffectView : public QObject
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
manageVSTEffectView( VstEffect * _eff, VstEffectControls * m_vi );
|
|
virtual ~manageVSTEffectView();
|
|
|
|
|
|
protected slots:
|
|
void syncPlugin( void );
|
|
void displayAutomatedOnly( void );
|
|
void setParameter( void );
|
|
void closeWindow();
|
|
|
|
private:
|
|
|
|
// static QPixmap * s_artwork;
|
|
|
|
VstEffectControls * m_vi2;
|
|
|
|
|
|
VstEffect * m_effect;
|
|
|
|
|
|
QWidget *widget;
|
|
QGridLayout * l;
|
|
|
|
QPushButton * m_syncButton;
|
|
QPushButton * m_displayAutomatedOnly;
|
|
QPushButton * m_closeButton;
|
|
Knob ** vstKnobs;
|
|
|
|
} ;
|
|
|
|
|
|
#endif
|