mirror of
https://github.com/LMMS/lmms.git
synced 2026-02-07 21:24:13 -05:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
130 lines
3.0 KiB
C++
130 lines
3.0 KiB
C++
/*
|
|
* Lv2ViewBase.h - base class for Lv2 plugin views
|
|
*
|
|
* Copyright (c) 2018-2023 Johannes Lorenz <jlsf2013$users.sourceforge.net, $=@>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_LV2_VIEW_BASE_H
|
|
#define LMMS_GUI_LV2_VIEW_BASE_H
|
|
|
|
#include "lmmsconfig.h"
|
|
|
|
#ifdef LMMS_HAVE_LV2
|
|
|
|
|
|
#include "LinkedModelGroupViews.h"
|
|
#include "lmms_export.h"
|
|
#include "Lv2Basics.h"
|
|
|
|
|
|
class QPushButton;
|
|
class QMdiSubWindow;
|
|
namespace lmms
|
|
{
|
|
|
|
|
|
class Lv2Proc;
|
|
class Lv2ControlBase;
|
|
|
|
|
|
namespace gui
|
|
{
|
|
|
|
|
|
//! View for one processor, Lv2ViewBase contains 2 of those for mono plugins
|
|
class Lv2ViewProc : public LinkedModelGroupView
|
|
{
|
|
public:
|
|
//! @param colNum numbers of columns for the controls
|
|
Lv2ViewProc(QWidget *parent, Lv2Proc *proc, int colNum);
|
|
~Lv2ViewProc() override = default;
|
|
|
|
private:
|
|
static AutoLilvNode uri(const char *uriStr);
|
|
};
|
|
|
|
|
|
|
|
|
|
class HelpWindowEventFilter : public QObject
|
|
{
|
|
Q_OBJECT
|
|
class Lv2ViewBase* const m_viewBase;
|
|
protected:
|
|
bool eventFilter(QObject* obj, QEvent* event) override;
|
|
public:
|
|
HelpWindowEventFilter(class Lv2ViewBase* viewBase);
|
|
};
|
|
|
|
|
|
|
|
|
|
//! Base class for view for one Lv2 plugin
|
|
class LMMS_EXPORT Lv2ViewBase : public LinkedModelGroupsView
|
|
{
|
|
friend class HelpWindowEventFilter;
|
|
protected:
|
|
//! @param pluginWidget A child class which inherits QWidget
|
|
Lv2ViewBase(class QWidget *pluginWidget, Lv2ControlBase *ctrlBase);
|
|
~Lv2ViewBase();
|
|
|
|
// these widgets must be connected by child widgets
|
|
QPushButton* m_reloadPluginButton = nullptr;
|
|
QPushButton* m_toggleUIButton = nullptr;
|
|
QPushButton* m_helpButton = nullptr;
|
|
|
|
void toggleUI();
|
|
void toggleHelp(bool visible);
|
|
void closeHelpWindow();
|
|
|
|
// to be called by child virtuals
|
|
//! Reconnect models if model changed
|
|
void modelChanged(Lv2ControlBase* ctrlBase);
|
|
|
|
private:
|
|
enum Rows
|
|
{
|
|
ButtonRow,
|
|
ProcRow,
|
|
LinkChannelsRow
|
|
};
|
|
|
|
static AutoLilvNode uri(const char *uriStr);
|
|
LinkedModelGroupView* getGroupView() override { return m_procView; }
|
|
void onHelpWindowClosed();
|
|
|
|
Lv2ViewProc* m_procView;
|
|
|
|
//! Numbers of controls per row; must be multiple of 2 for mono effects
|
|
const int m_colNum = 6;
|
|
QMdiSubWindow* m_helpWindow = nullptr;
|
|
HelpWindowEventFilter m_helpWindowEventFilter;
|
|
};
|
|
|
|
|
|
} // namespace gui
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_HAVE_LV2
|
|
|
|
#endif // LMMS_GUI_LV2_VIEW_BASE_H
|