mirror of
https://github.com/LMMS/lmms.git
synced 2026-03-26 09:53:03 -04:00
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
107 lines
2.9 KiB
C++
107 lines
2.9 KiB
C++
/*
|
|
* GuiApplication.h
|
|
*
|
|
* Copyright (c) 2014 Lukas W <lukaswhl/at/gmail.com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_GUI_APPLICATION_H
|
|
#define LMMS_GUI_GUI_APPLICATION_H
|
|
|
|
#include <QObject>
|
|
|
|
#include "lmms_export.h"
|
|
#include "lmmsconfig.h"
|
|
|
|
class QLabel;
|
|
class QSocketNotifier;
|
|
|
|
namespace lmms::gui
|
|
{
|
|
|
|
class AutomationEditorWindow;
|
|
class ControllerRackView;
|
|
class MixerView;
|
|
class MainWindow;
|
|
class MicrotunerConfig;
|
|
class PatternEditorWindow;
|
|
class PianoRollWindow;
|
|
class ProjectNotes;
|
|
class SongEditorWindow;
|
|
|
|
class LMMS_EXPORT GuiApplication : public QObject
|
|
{
|
|
Q_OBJECT;
|
|
public:
|
|
explicit GuiApplication();
|
|
~GuiApplication() override;
|
|
|
|
static GuiApplication* instance();
|
|
static void sigintHandler(int);
|
|
static bool isWayland();
|
|
#ifdef LMMS_BUILD_WIN32
|
|
static QFont getWin32SystemFont();
|
|
#endif
|
|
|
|
void createSocketNotifier();
|
|
|
|
MainWindow* mainWindow() { return m_mainWindow; }
|
|
MixerView* mixerView() { return m_mixerView; }
|
|
SongEditorWindow* songEditor() { return m_songEditor; }
|
|
PatternEditorWindow* patternEditor() { return m_patternEditor; }
|
|
PianoRollWindow* pianoRoll() { return m_pianoRoll; }
|
|
ProjectNotes* getProjectNotes() { return m_projectNotes; }
|
|
MicrotunerConfig* getMicrotunerConfig() { return m_microtunerConfig; }
|
|
AutomationEditorWindow* automationEditor() { return m_automationEditor; }
|
|
ControllerRackView* getControllerRackView() { return m_controllerRackView; }
|
|
|
|
//! File descriptors for unix socketpair, used to receive SIGINT
|
|
static inline int s_sigintFd[2];
|
|
|
|
public slots:
|
|
void displayInitProgress(const QString &msg);
|
|
|
|
private slots:
|
|
void childDestroyed(QObject *obj);
|
|
void sigintOccurred();
|
|
|
|
private:
|
|
static GuiApplication* s_instance;
|
|
|
|
MainWindow* m_mainWindow;
|
|
MixerView* m_mixerView;
|
|
SongEditorWindow* m_songEditor;
|
|
AutomationEditorWindow* m_automationEditor;
|
|
PatternEditorWindow* m_patternEditor;
|
|
PianoRollWindow* m_pianoRoll;
|
|
ProjectNotes* m_projectNotes;
|
|
MicrotunerConfig* m_microtunerConfig;
|
|
ControllerRackView* m_controllerRackView;
|
|
QLabel* m_loadingProgressLabel;
|
|
QSocketNotifier* m_sigintNotifier;
|
|
};
|
|
|
|
// Short-hand function
|
|
LMMS_EXPORT GuiApplication* getGUI();
|
|
|
|
} // namespace lmms::gui
|
|
|
|
#endif // LMMS_GUI_GUI_APPLICATION_H
|