mirror of
https://github.com/LMMS/lmms.git
synced 2026-03-26 09:53:03 -04:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
76 lines
1.8 KiB
C++
76 lines
1.8 KiB
C++
/*
|
|
* DispersionControls.h
|
|
*
|
|
* Copyright (c) 2023 Lost Robot <r94231/at/gmail/dot/com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_DISPERSION_CONTROLS_H
|
|
#define LMMS_DISPERSION_CONTROLS_H
|
|
|
|
#include "DispersionControlDialog.h"
|
|
#include "EffectControls.h"
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
class DispersionEffect;
|
|
|
|
class DispersionControls : public EffectControls
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
DispersionControls(DispersionEffect* effect);
|
|
~DispersionControls() override = default;
|
|
|
|
void saveSettings(QDomDocument & doc, QDomElement & parent) override;
|
|
void loadSettings(const QDomElement & parent) override;
|
|
inline QString nodeName() const override
|
|
{
|
|
return "DispersionControls";
|
|
}
|
|
|
|
int controlCount() override
|
|
{
|
|
return 5;
|
|
}
|
|
|
|
gui::EffectControlDialog* createView() override
|
|
{
|
|
return new gui::DispersionControlDialog(this);
|
|
}
|
|
|
|
private:
|
|
DispersionEffect* m_effect;
|
|
IntModel m_amountModel;
|
|
FloatModel m_freqModel;
|
|
FloatModel m_resoModel;
|
|
FloatModel m_feedbackModel;
|
|
BoolModel m_dcModel;
|
|
|
|
friend class gui::DispersionControlDialog;
|
|
friend class DispersionEffect;
|
|
};
|
|
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_DISPERSION_CONTROLS_H
|