mirror of
https://github.com/LMMS/lmms.git
synced 2026-03-26 18:03:33 -04:00
71ce49d7ba
Follow-Up of 7db3fa94a1 .
This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):
```
include-what-you-use;
-Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
-Xiwyu;--keep=*/xmmintrin.h;
-Xiwyu;--keep=*/lmmsconfig.h;
-Xiwyu;--keep=*/weak_libjack.h;
-Xiwyu;--keep=*/sys/*;
-Xiwyu;--keep=*/debug.h;
-Xiwyu;--keep=*/SDL/*;
-Xiwyu;--keep=*/alsa/*;
-Xiwyu;--keep=*/FL/x.h;
-Xiwyu;--keep=*/MidiApple.h;
-Xiwyu;--keep=*/MidiWinMM.h;
-Xiwyu;--keep=*/AudioSoundIo.h;
-Xiwyu;--keep=*/OpulenZ/adplug/*;
-Xiwyu;--keep=QPainterPath;
-Xiwyu;--keep=QtTest
```
FAQ:
* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.
* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
that your compiler needs to recompile, or your IDE has to re-scan.
* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
reduce output for those who want to use IWYU for new PRs.
Background:
This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.
However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
125 lines
3.6 KiB
C++
125 lines
3.6 KiB
C++
/*
|
|
* LOMMControlDialog.h
|
|
*
|
|
* Copyright (c) 2023 Lost Robot <r94231/at/gmail/dot/com>
|
|
*
|
|
* This file is part of LMMS - https://lmms.io
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public
|
|
* License along with this program (see COPYING); if not, write to the
|
|
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
|
|
* Boston, MA 02110-1301 USA.
|
|
*
|
|
*/
|
|
|
|
#ifndef LMMS_GUI_LOMM_CONTROL_DIALOG_H
|
|
#define LMMS_GUI_LOMM_CONTROL_DIALOG_H
|
|
|
|
#include "EffectControlDialog.h"
|
|
|
|
|
|
#include "embed.h"
|
|
#include "Knob.h"
|
|
#include "LcdFloatSpinBox.h"
|
|
#include "PixmapButton.h"
|
|
|
|
namespace lmms
|
|
{
|
|
|
|
inline constexpr float LOMM_DISPLAY_MIN = -72;
|
|
inline constexpr float LOMM_DISPLAY_MAX = 0;
|
|
inline constexpr float LOMM_DISPLAY_X = 125;
|
|
inline constexpr float LOMM_DISPLAY_Y[6] = {24, 41, 106, 123, 186, 203};
|
|
inline constexpr float LOMM_DISPLAY_WIDTH = 150;
|
|
inline constexpr float LOMM_DISPLAY_HEIGHT = 13;
|
|
inline constexpr float LOMM_DISPLAY_DB_PER_PIXEL = (LOMM_DISPLAY_MAX - LOMM_DISPLAY_MIN) / LOMM_DISPLAY_WIDTH;
|
|
|
|
class LOMMControls;
|
|
|
|
|
|
namespace gui
|
|
{
|
|
|
|
class LOMMControlDialog : public EffectControlDialog
|
|
{
|
|
Q_OBJECT
|
|
public:
|
|
LOMMControlDialog(LOMMControls* controls);
|
|
~LOMMControlDialog() override = default;
|
|
|
|
int dbfsToX(float dbfs);
|
|
float xToDbfs(int x);
|
|
|
|
Knob* createKnob(KnobType knobType, QWidget* parent, int x, int y, FloatModel* model, const QString& hintText, const QString& unit, const QString& toolTip)
|
|
{
|
|
Knob* knob = new Knob(knobType, parent);
|
|
knob->move(x, y);
|
|
knob->setModel(model);
|
|
knob->setHintText(hintText, unit);
|
|
knob->setToolTip(toolTip);
|
|
return knob;
|
|
}
|
|
|
|
LcdFloatSpinBox* createLcdFloatSpinBox(int integerDigits, int decimalDigits, const QString& color, const QString& unit, QWidget* parent, int x, int y, FloatModel* model, const QString& toolTip)
|
|
{
|
|
LcdFloatSpinBox* spinBox = new LcdFloatSpinBox(integerDigits, decimalDigits, color, unit, parent);
|
|
spinBox->move(x, y);
|
|
spinBox->setModel(model);
|
|
spinBox->setSeamless(true, true);
|
|
spinBox->setToolTip(toolTip);
|
|
return spinBox;
|
|
}
|
|
|
|
PixmapButton* createPixmapButton(const QString& text, QWidget* parent, int x, int y, BoolModel* model,
|
|
std::string_view activeIcon, std::string_view inactiveIcon, const QString& tooltip)
|
|
{
|
|
PixmapButton* button = new PixmapButton(parent, text);
|
|
button->move(x, y);
|
|
button->setCheckable(true);
|
|
if (model) { button->setModel(model); }
|
|
button->setActiveGraphic(PLUGIN_NAME::getIconPixmap(activeIcon));
|
|
button->setInactiveGraphic(PLUGIN_NAME::getIconPixmap(inactiveIcon));
|
|
button->setToolTip(tooltip);
|
|
return button;
|
|
}
|
|
|
|
protected:
|
|
void paintEvent(QPaintEvent *event) override;
|
|
void mousePressEvent(QMouseEvent* event) override;
|
|
void mouseReleaseEvent(QMouseEvent* event) override;
|
|
void mouseMoveEvent(QMouseEvent* event) override;
|
|
|
|
private:
|
|
LOMMControls* m_controls;
|
|
|
|
QPoint m_lastMousePos;
|
|
bool m_buttonPressed = false;
|
|
int m_bandDrag = 0;
|
|
int m_dragType = -1;
|
|
|
|
PixmapButton* m_feedbackButton;
|
|
PixmapButton* m_lowSideUpwardSuppressButton;
|
|
|
|
private slots:
|
|
void updateFeedbackVisibility();
|
|
void updateLowSideUpwardSuppressVisibility();
|
|
void updateDisplay();
|
|
};
|
|
|
|
|
|
} // namespace gui
|
|
|
|
} // namespace lmms
|
|
|
|
#endif // LMMS_GUI_LOMM_CONTROL_DIALOG_H
|