Files
lmms/plugins/LadspaBrowser/LadspaDescription.cpp
Johannes Lorenz 71ce49d7ba Remove lots of useless/misplaced includes (#7999)
Follow-Up of 7db3fa94a1 .

This was done by setting `CMAKE_C_INCLUDE_WHAT_YOU_USE` and
`CMAKE_CXX_INCLUDE_WHAT_YOU_USE` to (broken down into multiple lines here,
note, all below `FL/x.h` is not required for C):

```
include-what-you-use;
    -Xiwyu;--mapping_file=/usr/share/include-what-you-use/qt5_11.imp;
    -Xiwyu;--keep=*/xmmintrin.h;
    -Xiwyu;--keep=*/lmmsconfig.h;
    -Xiwyu;--keep=*/weak_libjack.h;
    -Xiwyu;--keep=*/sys/*;
    -Xiwyu;--keep=*/debug.h;
    -Xiwyu;--keep=*/SDL/*;
    -Xiwyu;--keep=*/alsa/*;
    -Xiwyu;--keep=*/FL/x.h;
    -Xiwyu;--keep=*/MidiApple.h;
    -Xiwyu;--keep=*/MidiWinMM.h;
    -Xiwyu;--keep=*/AudioSoundIo.h;
    -Xiwyu;--keep=*/OpulenZ/adplug/*;
    -Xiwyu;--keep=QPainterPath;
    -Xiwyu;--keep=QtTest
```

FAQ:

* Q: Does this speed-up a completely fresh compile?
* A: No, I measured it.

* Q: Does it speed up anything else?
* A: Yes. If you change one header, it can reduce the number of CPP files
     that your compiler needs to recompile, or your IDE has to re-scan.

* Q: What other reasons are for this PR?
* A: It's idiomatic to only include headers if you need them. Also, it will
     reduce output for those who want to use IWYU for new PRs.

Background:

This is just a remainder PR of what I planned. My original idea was to setup
a CI which warns you of useless includes (but not of all issues that IWYU
complains about). However, I could not see that this was favored on Discord.
A full IWYU CI also has the problem that it (possibly??) needs to compile
with `make -j 1`, which would make CI really slow.

However, for that plan, I had to fix the whole code base to be IWYU
compliant - which it now is.
2025-07-21 23:39:17 +02:00

182 lines
5.0 KiB
C++

/*
* LadspaDescription.cpp - LADSPA plugin description
*
* Copyright (c) 2007 Javier Serrano Polo <jasp00/at/users.sourceforge.net>
*
* This file is part of LMMS - https://lmms.io
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public
* License as published by the Free Software Foundation; either
* version 2 of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public
* License along with this program (see COPYING); if not, write to the
* Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
* Boston, MA 02110-1301 USA.
*
*/
#include "LadspaDescription.h"
#include <QGroupBox>
#include <QLabel>
#include <QListWidget>
#include <QScrollArea>
#include <QVBoxLayout>
#include "Engine.h"
#include "Ladspa2LMMS.h"
#include "lmms_constants.h"
namespace lmms::gui
{
LadspaDescription::LadspaDescription( QWidget * _parent,
LadspaPluginType _type ) :
QWidget( _parent )
{
Ladspa2LMMS * manager = Engine::getLADSPAManager();
l_sortable_plugin_t plugins;
switch( _type )
{
case LadspaPluginType::Source:
plugins = manager->getInstruments();
break;
case LadspaPluginType::Transfer:
plugins = manager->getValidEffects();
break;
case LadspaPluginType::Valid:
plugins = manager->getValidEffects();
break;
case LadspaPluginType::Invalid:
plugins = manager->getInvalidEffects();
break;
case LadspaPluginType::Sink:
plugins = manager->getAnalysisTools();
break;
case LadspaPluginType::Other:
plugins = manager->getOthers();
break;
default:
break;
}
QList<QString> pluginNames;
for (const auto& plugin : plugins)
{
if (_type != LadspaPluginType::Valid || manager->getDescription(plugin.second)->inputChannels <= DEFAULT_CHANNELS)
{
pluginNames.push_back(plugin.first);
m_pluginKeys.push_back(plugin.second);
}
}
auto pluginsBox = new QGroupBox(tr("Plugins"), this);
auto pluginList = new QListWidget(pluginsBox);
pluginList->addItems( pluginNames );
connect( pluginList, SIGNAL( currentRowChanged( int ) ),
SLOT( rowChanged( int ) ) );
connect( pluginList, SIGNAL( itemDoubleClicked( QListWidgetItem * ) ),
SLOT( onDoubleClicked( QListWidgetItem * ) ) );
( new QVBoxLayout( pluginsBox ) )->addWidget( pluginList );
auto descriptionBox = new QGroupBox(tr("Description"), this);
auto descriptionLayout = new QVBoxLayout(descriptionBox);
descriptionLayout->setSpacing( 0 );
descriptionLayout->setContentsMargins(0, 0, 0, 0);
m_scrollArea = new QScrollArea( descriptionBox );
descriptionLayout->addWidget( m_scrollArea );
auto layout = new QVBoxLayout(this);
layout->addWidget( pluginsBox );
layout->addWidget( descriptionBox );
if( pluginList->count() > 0 )
{
pluginList->setCurrentRow( 0 );
m_currentSelection = m_pluginKeys[0];
update( m_currentSelection );
}
}
void LadspaDescription::update( const ladspa_key_t & _key )
{
auto description = new QWidget;
m_scrollArea->setWidget( description );
auto layout = new QVBoxLayout(description);
layout->setSizeConstraint( QLayout::SetFixedSize );
Ladspa2LMMS * manager = Engine::getLADSPAManager();
auto name = new QLabel(description);
name->setText(tr("Name: ") + manager->getName(_key));
layout->addWidget( name );
auto maker = new QLabel(description);
maker->setText(tr("Maker: ") + manager->getMaker(_key));
layout->addWidget( maker );
auto copyright = new QLabel(description);
copyright->setText(tr("Copyright: ") + manager->getCopyright(_key));
layout->addWidget( copyright );
auto requiresRealTime = new QLabel(description);
requiresRealTime->setText(tr("Requires Real Time: ") +
(manager->hasRealTimeDependency(_key) ? tr("Yes") : tr("No")));
layout->addWidget( requiresRealTime );
auto realTimeCapable = new QLabel(description);
realTimeCapable->setText(tr("Real Time Capable: ") +
(manager->isRealTimeCapable(_key) ? tr("Yes") : tr("No")));
layout->addWidget( realTimeCapable );
auto inplaceBroken = new QLabel(description);
inplaceBroken->setText(tr("In Place Broken: ") +
(manager->isInplaceBroken(_key) ? tr("Yes") : tr("No")));
layout->addWidget( inplaceBroken );
auto channelsIn = new QLabel(description);
channelsIn->setText(tr("Channels In: ") + QString::number(
manager->getDescription( _key )->inputChannels ) );
layout->addWidget( channelsIn );
auto channelsOut = new QLabel(description);
channelsOut->setText(tr("Channels Out: ") + QString::number(
manager->getDescription( _key )->outputChannels ) );
layout->addWidget( channelsOut );
}
void LadspaDescription::rowChanged( int _pluginIndex )
{
m_currentSelection = m_pluginKeys[_pluginIndex];
update( m_currentSelection );
}
void LadspaDescription::onDoubleClicked( QListWidgetItem * _item )
{
emit( doubleClicked( m_currentSelection ) );
}
} // namespace lmms::gui