From 1155f7561271dc2d4d64f0ea4d5af4571391c174 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jorge=20Mart=C3=ADn?= <jorgem@element.io>
Date: Thu, 8 Aug 2024 13:15:08 +0200
Subject: [PATCH] fixup! fix review comments

---
 crates/matrix-sdk-base/src/sliding_sync/mod.rs | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/crates/matrix-sdk-base/src/sliding_sync/mod.rs b/crates/matrix-sdk-base/src/sliding_sync/mod.rs
index 3cff3558d..7f218ec52 100644
--- a/crates/matrix-sdk-base/src/sliding_sync/mod.rs
+++ b/crates/matrix-sdk-base/src/sliding_sync/mod.rs
@@ -626,10 +626,11 @@ impl BaseClient {
                     let new_state: RoomState = member.membership().into();
                     if new_state != room_info.state() {
                         room_info.set_state(new_state);
-                        room_info_notable_updates.insert(
-                            room_info.room_id.to_owned(),
-                            RoomInfoNotableUpdateReasons::MEMBERSHIP,
-                        );
+                        // Update an existing notable update entry or create a new one
+                        room_info_notable_updates
+                            .entry(room_info.room_id.to_owned())
+                            .or_default()
+                            .insert(RoomInfoNotableUpdateReasons::MEMBERSHIP);
                     }
                     break;
                 }