From 44443d3b46b6876f3fa721db26cb04a446b40ada Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Damir=20Jeli=C4=87?= <poljar@termina.org.uk>
Date: Tue, 19 Mar 2024 18:55:44 +0100
Subject: [PATCH] crypto: Mac then decrypt in the PkDecryption compat module

---
 crates/matrix-sdk-crypto/src/backups/keys/compat.rs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/crates/matrix-sdk-crypto/src/backups/keys/compat.rs b/crates/matrix-sdk-crypto/src/backups/keys/compat.rs
index e5eb01612..59c32e6ad 100644
--- a/crates/matrix-sdk-crypto/src/backups/keys/compat.rs
+++ b/crates/matrix-sdk-crypto/src/backups/keys/compat.rs
@@ -106,12 +106,12 @@ impl PkDecryption {
 
         let keys = Keys::new(shared_secret);
 
-        let cipher = Aes256CbcDec::new(keys.aes_key(), keys.iv());
-        let decrypted = cipher.decrypt_padded_vec_mut::<Pkcs7>(&message.ciphertext)?;
-
         let hmac = keys.hmac();
         hmac.verify_truncated_left(&message.mac)?;
 
+        let cipher = Aes256CbcDec::new(keys.aes_key(), keys.iv());
+        let decrypted = cipher.decrypt_padded_vec_mut::<Pkcs7>(&message.ciphertext)?;
+
         Ok(decrypted)
     }