From 52c38ec44d8ea2f9e29dee5cc625c056c0e744a6 Mon Sep 17 00:00:00 2001 From: Ivan Enderlin Date: Wed, 14 May 2025 17:17:59 +0200 Subject: [PATCH] refactor(base): Remove `SlidingSync::get_room`. This patch removes the `SlidingSync::get_room` method. The goal is to remove `SlidingSyncRoom`. --- .../matrix-sdk-ui/tests/integration/timeline/sliding_sync.rs | 5 ----- crates/matrix-sdk/src/sliding_sync/mod.rs | 5 ----- 2 files changed, 10 deletions(-) diff --git a/crates/matrix-sdk-ui/tests/integration/timeline/sliding_sync.rs b/crates/matrix-sdk-ui/tests/integration/timeline/sliding_sync.rs index 19ba81d62..1aca8c949 100644 --- a/crates/matrix-sdk-ui/tests/integration/timeline/sliding_sync.rs +++ b/crates/matrix-sdk-ui/tests/integration/timeline/sliding_sync.rs @@ -394,8 +394,6 @@ async fn create_one_room( assert!(update.rooms.contains(&room_id.to_owned())); - let _room = sliding_sync.get_room(room_id).await.context("`get_room`")?; - Ok(()) } @@ -404,9 +402,6 @@ async fn timeline_test_helper( sliding_sync: &SlidingSync, room_id: &RoomId, ) -> Result<(Vector>, impl Stream>>>)> { - let sliding_sync_room = sliding_sync.get_room(room_id).await.unwrap(); - - let room_id = sliding_sync_room.room_id(); let sdk_room = client.get_room(room_id).ok_or_else(|| { anyhow::anyhow!("Room {room_id} not found in client. Can't provide a timeline for it") })?; diff --git a/crates/matrix-sdk/src/sliding_sync/mod.rs b/crates/matrix-sdk/src/sliding_sync/mod.rs index 093332449..0e183e4a8 100644 --- a/crates/matrix-sdk/src/sliding_sync/mod.rs +++ b/crates/matrix-sdk/src/sliding_sync/mod.rs @@ -180,11 +180,6 @@ impl SlidingSync { } } - /// Lookup a specific room - pub async fn get_room(&self, room_id: &RoomId) -> Option { - self.inner.rooms.read().await.get(room_id).cloned() - } - /// Check the number of rooms. pub fn get_number_of_rooms(&self) -> usize { self.inner.rooms.blocking_read().len()