From cc7fb63c6d5e245b4e5216d0d3dec7c218f49007 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Commaille?= Date: Mon, 3 Mar 2025 03:32:21 +0100 Subject: [PATCH] refactor(sdk): Remove clone_request method MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit http::Request implements Clone since http 1.0.0 Signed-off-by: Kévin Commaille --- crates/matrix-sdk/src/http_client/native.rs | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/crates/matrix-sdk/src/http_client/native.rs b/crates/matrix-sdk/src/http_client/native.rs index 102c2d7e8..b3d36fd3d 100644 --- a/crates/matrix-sdk/src/http_client/native.rs +++ b/crates/matrix-sdk/src/http_client/native.rs @@ -195,7 +195,7 @@ pub(super) async fn send_request( use futures_util::stream; - let request = clone_request(request); + let request = request.clone(); let request = { let mut request = if send_progress.subscriber_count() != 0 { let content_length = request.body().len(); @@ -234,17 +234,6 @@ pub(super) async fn send_request( Ok(response_to_http_response(response).await?) } -// Clones all request parts except the extensions which can't be cloned. -// See also https://github.com/hyperium/http/issues/395 -fn clone_request(request: &http::Request) -> http::Request { - let mut builder = http::Request::builder() - .version(request.version()) - .method(request.method()) - .uri(request.uri()); - *builder.headers_mut().unwrap() = request.headers().clone(); - builder.body(request.body().clone()).unwrap() -} - struct BytesChunks { bytes: Bytes, size: usize,