From d800d3c324d723afe35271a3958bb23c3dc78b2e Mon Sep 17 00:00:00 2001
From: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Date: Mon, 28 Apr 2025 13:55:51 +0100
Subject: [PATCH] crypto: clean up confusing method (#4983)

This method had a confusing name: it didn't receive a key bundle, but
rather the data *about* a key bundle.

Remove the unused `sender_key` parameter while we are at it: we use the
embedded (and already-checked) `event.sender_device_keys` here.
---
 crates/matrix-sdk-crypto/src/machine/mod.rs | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/crates/matrix-sdk-crypto/src/machine/mod.rs b/crates/matrix-sdk-crypto/src/machine/mod.rs
index 38c49ffe7..bf36b420b 100644
--- a/crates/matrix-sdk-crypto/src/machine/mod.rs
+++ b/crates/matrix-sdk-crypto/src/machine/mod.rs
@@ -939,10 +939,11 @@ impl OlmMachine {
         }
     }
 
+    /// Handle a received, decrypted, `io.element.msc4268.room_key_bundle`
+    /// to-device event.
     #[instrument()]
-    async fn receive_room_key_bundle(
+    async fn receive_room_key_bundle_data(
         &self,
-        sender_key: Curve25519PublicKey,
         event: &DecryptedRoomKeyBundleEvent,
         changes: &mut Changes,
     ) -> OlmResult<()> {
@@ -1206,7 +1207,7 @@ impl OlmMachine {
             }
             AnyDecryptedOlmEvent::RoomKeyBundle(e) => {
                 debug!("Received a room key bundle event {:?}", e);
-                self.receive_room_key_bundle(decrypted.result.sender_key, e, changes).await?;
+                self.receive_room_key_bundle_data(e, changes).await?;
             }
             AnyDecryptedOlmEvent::Custom(_) => {
                 warn!("Received an unexpected encrypted to-device event");