From fbeb77ae3ee99f485e1b799a6fcc5faeced74334 Mon Sep 17 00:00:00 2001 From: Benjamin Bouvier Date: Tue, 2 Jul 2024 12:13:21 +0200 Subject: [PATCH] sdk-store-encryption: use `ZeroizeOnDrop` instead of `[zeroize(drop)]` One item of https://github.com/matrix-org/matrix-rust-sdk/issues/3272. --- crates/matrix-sdk-store-encryption/src/lib.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/crates/matrix-sdk-store-encryption/src/lib.rs b/crates/matrix-sdk-store-encryption/src/lib.rs index a29b8d44e..55792a885 100644 --- a/crates/matrix-sdk-store-encryption/src/lib.rs +++ b/crates/matrix-sdk-store-encryption/src/lib.rs @@ -33,7 +33,7 @@ use pbkdf2::pbkdf2; use rand::{thread_rng, Error as RandomError, Fill}; use serde::{de::DeserializeOwned, Deserialize, Serialize}; use sha2::Sha256; -use zeroize::Zeroize; +use zeroize::{Zeroize, ZeroizeOnDrop}; const VERSION: u8 = 1; const KDF_SALT_SIZE: usize = 32; @@ -774,8 +774,7 @@ impl StoreCipher { } } -#[derive(Zeroize)] -#[zeroize(drop)] +#[derive(ZeroizeOnDrop)] struct MacKey(Box<[u8; 32]>); impl MacKey { @@ -878,8 +877,7 @@ impl From for EncryptedValueBase64 { } } -#[derive(Zeroize)] -#[zeroize(drop)] +#[derive(ZeroizeOnDrop)] struct Keys { encryption_key: Box<[u8; 32]>, mac_key_seed: Box,