mirror/navidrome
1
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2025-12-23 23:18:05 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat(scanner): improve error messages for cleanup operations in annotations, bookmarks, and tags

Browse Source 
Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan
2025-11-20 09:27:42 -05:00
parent 0c3012bbbd
commit 36fa869329
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
persistence/sql_annotations.go
View File

@@ -119,7 +119,7 @@ func (r sqlRepository) cleanAnnotations() error {
del := Delete(annotationTable).Where(Eq{"item_type": r.tableName}).Where("item_id not in (select id from " + r.tableName + ")") del := Delete(annotationTable).Where(Eq{"item_type": r.tableName}).Where("item_id not in (select id from " + r.tableName + ")")
c, err := r.executeSQL(del) c, err := r.executeSQL(del)
if err != nil { if err != nil {
return fmt.Errorf("error cleaning up annotations: %w", err) return fmt.Errorf("error cleaning up %s annotations: %w", r.tableName, err)
} }
if c > 0 { if c > 0 {
log.Debug(r.ctx, "Clean-up annotations", "table", r.tableName, "totalDeleted", c) log.Debug(r.ctx, "Clean-up annotations", "table", r.tableName, "totalDeleted", c)

4
persistence/sql_bookmarks.go
View File

@@ -148,10 +148,10 @@ func (r sqlRepository) cleanBookmarks() error {
del := Delete(bookmarkTable).Where(Eq{"item_type": r.tableName}).Where("item_id not in (select id from " + r.tableName + ")") del := Delete(bookmarkTable).Where(Eq{"item_type": r.tableName}).Where("item_id not in (select id from " + r.tableName + ")")
c, err := r.executeSQL(del) c, err := r.executeSQL(del)
if err != nil { if err != nil {
return fmt.Errorf("error cleaning up bookmarks: %w", err) return fmt.Errorf("error cleaning up %s bookmarks: %w", r.tableName, err)
} }
if c > 0 { if c > 0 {
log.Debug(r.ctx, "Clean-up bookmarks", "totalDeleted", c) log.Debug(r.ctx, "Clean-up bookmarks", "totalDeleted", c, "itemType", r.tableName)
} }
return nil return nil
} }

4
persistence/tag_repository.go
View File

@@ -88,10 +88,10 @@ func (r *tagRepository) purgeUnused() error {
`) `)
c, err := r.executeSQL(del) c, err := r.executeSQL(del)
if err != nil { if err != nil {
return fmt.Errorf("error purging unused tags: %w", err) return fmt.Errorf("error purging %s unused tags: %w", r.tableName, err)
} }
if c > 0 { if c > 0 {
log.Debug(r.ctx, "Purged unused tags", "totalDeleted", c) log.Debug(r.ctx, "Purged unused tags", "totalDeleted", c, "table", r.tableName)
} }
return err return err
} }