Files
navidrome/plugins/manager_plugin.go
Deluan Quintão 756df9decf fix: dedupe and cap concurrent lyrics plugin fetches (#5792)
* fix: dedupe and cap concurrent lyrics plugin fetches

Clients like Finamp prefetch lyrics for several queue tracks at once. The
resulting burst of concurrent plugin calls can rate-limit the primary
lyrics provider into a timeout, making the plugin fall back to a lower
quality source and cache the bad result.

SimpleCache.GetWithLoader now deduplicates concurrent loads of the same
key via singleflight, with every waiter receiving the winner's result or
error. The Jellyfin lyrics loader is detached from the request context so
one cancelled request cannot fail the load for all waiters, and the
lyrics adapter caps in-flight plugin calls at 2 per plugin, queueing the
rest. As a side effect, the cached HTTP client used by the Last.fm,
Deezer and ListenBrainz agents also collapses identical concurrent
requests into a single upstream call.

* fix: harden lyrics concurrency fixes per review

Replace the stringified singleflight keys with a per-cache flight map
keyed by the cache key type itself, eliminating potential key collisions
for non-string keys, the nil-interface assertion panic, and the
stringification overhead. Release the lyrics semaphore slot via defer so
a panicking plugin call cannot leak it, and bound the detached lyrics
load with a one-minute timeout so a hung plugin cannot pin its
singleflight and semaphore slot indefinitely.
2026-07-16 20:10:35 -04:00

136 lines
4.2 KiB
Go

package plugins
import (
"context"
"crypto/rand"
"errors"
"fmt"
"io"
extism "github.com/extism/go-sdk"
"github.com/navidrome/navidrome/model"
"github.com/tetratelabs/wazero"
)
// plugin represents a loaded plugin
type plugin struct {
name string // Plugin name (from filename)
path string // Path to the wasm file
manifest *Manifest
compiled *extism.CompiledPlugin
capabilities []Capability // Auto-detected capabilities based on exported functions
closers []io.Closer // Cleanup functions to call on unload
metrics PluginMetricsRecorder
allowedUserIDs []string // User IDs this plugin can access (from DB configuration)
allUsers bool // If true, plugin can access all users
libraries libraryAccess
lyricsSem chan struct{} // Caps concurrent lyrics calls (see LyricsPlugin.GetLyrics)
}
// instance creates a new plugin instance for the given context.
// The context is used for cancellation - if cancelled during a call,
// the module will be terminated and the instance becomes unusable.
func (p *plugin) instance(ctx context.Context) (*extism.Plugin, error) {
instance, err := p.compiled.Instance(ctx, extism.PluginInstanceConfig{
ModuleConfig: wazero.NewModuleConfig().WithSysWalltime().WithRandSource(rand.Reader),
})
if err != nil {
return nil, err
}
instance.SetLogger(extismLogger(p.name))
return instance, nil
}
func (p *plugin) Close() error {
var errs []error
for _, f := range p.closers {
err := f.Close()
if err != nil {
errs = append(errs, err)
}
}
return errors.Join(errs...)
}
func (p *plugin) hasLibraryFilesystemAccess(libID int) bool {
return p.manifest.HasLibraryFilesystemPermission() && p.libraries.contains(libID)
}
// libraryAccess captures the set of libraries a plugin is permitted to see,
// precomputed at load time for O(1) lookup.
type libraryAccess struct {
allLibraries bool
libraryIDSet map[int]struct{}
}
func newLibraryAccess(allowedLibraryIDs []int, allLibraries bool) libraryAccess {
set := make(map[int]struct{}, len(allowedLibraryIDs))
for _, id := range allowedLibraryIDs {
set[id] = struct{}{}
}
return libraryAccess{allLibraries: allLibraries, libraryIDSet: set}
}
func (a libraryAccess) contains(libID int) bool {
if a.allLibraries {
return true
}
_, ok := a.libraryIDSet[libID]
return ok
}
// configured reports whether the plugin has any library scope (all, or specific).
func (a libraryAccess) configured() bool {
return a.allLibraries || len(a.libraryIDSet) > 0
}
// userAccess captures the set of users a plugin is permitted to act as,
// precomputed at load time for O(1) lookup.
type userAccess struct {
allUsers bool
userIDSet map[string]struct{}
}
func newUserAccess(allowedUserIDs []string, allUsers bool) userAccess {
set := make(map[string]struct{}, len(allowedUserIDs))
for _, id := range allowedUserIDs {
set[id] = struct{}{}
}
return userAccess{allUsers: allUsers, userIDSet: set}
}
// allows reports whether the plugin may act as the given user ID.
func (a userAccess) allows(userID string) bool {
if a.allUsers {
return true
}
_, ok := a.userIDSet[userID]
return ok
}
// resolve looks up a user by username and authorizes it against this access set,
// distinguishing an absent user from a backend failure.
//
// When the plugin has no user scope at all, it rejects before the lookup with a
// single fixed error, so a caller cannot tell a real account from a missing one by
// the error text (username enumeration).
func (a userAccess) resolve(ctx context.Context, ds model.DataStore, username string) (*model.User, error) {
if !a.allUsers && len(a.userIDSet) == 0 {
return nil, fmt.Errorf("plugin is not authorized to scope by user")
}
usr, err := ds.User(ctx).FindByUsername(username)
if err != nil {
if errors.Is(err, model.ErrNotFound) {
return nil, fmt.Errorf("user %q not found", username)
}
return nil, fmt.Errorf("looking up user %q: %w", username, err)
}
if usr == nil { // defensive: a conforming repo returns ErrNotFound, not (nil, nil)
return nil, fmt.Errorf("user %q not found", username)
}
if !a.allows(usr.ID) {
return nil, fmt.Errorf("plugin is not allowed to act as user %q", username)
}
return usr, nil
}