mirror of
https://github.com/navidrome/navidrome.git
synced 2026-04-20 22:47:22 -04:00
* fix(server): capture ffmpeg stderr and warn on empty transcoded output When ffmpeg fails during transcoding (e.g., missing codec like libopus), the error was silently discarded because stderr was sent to io.Discard and the HTTP response returned 200 OK with a 0-byte body. - Capture ffmpeg stderr in a bounded buffer (4KB) and include it in the error message when the process exits with a non-zero status code - Log a warning when transcoded output is 0 bytes, guiding users to check codec support and enable Trace logging for details - Remove log level guard so transcoding errors are always logged, not just at Debug level Signed-off-by: Deluan <deluan@navidrome.org> * fix(server): return proper error responses for empty transcoded output Instead of returning HTTP 200 with 0-byte body when transcoding fails, return a Subsonic error response (for stream/download/getTranscodeStream) or HTTP 500 (for public shared streams). This gives clients a clear signal that the request failed rather than a misleading empty success. Signed-off-by: Deluan <deluan@navidrome.org> * test(e2e): add tests for empty transcoded stream error responses Add E2E tests verifying that stream and download endpoints return Subsonic error responses when transcoding produces empty output. Extend spyStreamer with SimulateEmptyStream and SimulateError fields to support failure injection in tests. Signed-off-by: Deluan <deluan@navidrome.org> * refactor(server): extract stream serving logic into Stream.Serve method Extract the duplicated non-seekable stream serving logic (header setup, estimateContentLength, HEAD draining, io.Copy with error/empty detection) from server/subsonic/stream.go and server/public/handle_streams.go into a single Stream.Serve method on core/stream. Both callers now delegate to it, eliminating ~30 lines of near-identical code. * fix(server): return 200 with empty body for stream/download on empty transcoded output Don't return a Subsonic error response when transcoding produces empty output on stream/download endpoints — just log the error and return 200 with an empty body. The getTranscodeStream and public share endpoints still return HTTP 500 for empty output. Stream.Serve now returns (int64, error) so callers can check the byte count. --------- Signed-off-by: Deluan <deluan@navidrome.org>
404 lines
13 KiB
Go
404 lines
13 KiB
Go
package subsonic
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"slices"
|
|
"strconv"
|
|
|
|
"github.com/navidrome/navidrome/core/stream"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/server/subsonic/responses"
|
|
"github.com/navidrome/navidrome/utils/req"
|
|
)
|
|
|
|
// API-layer request structs for JSON unmarshaling (decoupled from core structs)
|
|
|
|
// clientInfoRequest represents client playback capabilities from the request body
|
|
type clientInfoRequest struct {
|
|
Name string `json:"name,omitempty"`
|
|
Platform string `json:"platform,omitempty"`
|
|
MaxAudioBitrate int `json:"maxAudioBitrate,omitempty"`
|
|
MaxTranscodingAudioBitrate int `json:"maxTranscodingAudioBitrate,omitempty"`
|
|
DirectPlayProfiles []directPlayProfileRequest `json:"directPlayProfiles,omitempty"`
|
|
TranscodingProfiles []transcodingProfileRequest `json:"transcodingProfiles,omitempty"`
|
|
CodecProfiles []codecProfileRequest `json:"codecProfiles,omitempty"`
|
|
}
|
|
|
|
// directPlayProfileRequest describes a format the client can play directly
|
|
type directPlayProfileRequest struct {
|
|
Containers []string `json:"containers,omitempty"`
|
|
AudioCodecs []string `json:"audioCodecs,omitempty"`
|
|
Protocols []string `json:"protocols,omitempty"`
|
|
MaxAudioChannels int `json:"maxAudioChannels,omitempty"`
|
|
}
|
|
|
|
// transcodingProfileRequest describes a transcoding target the client supports
|
|
type transcodingProfileRequest struct {
|
|
Container string `json:"container,omitempty"`
|
|
AudioCodec string `json:"audioCodec,omitempty"`
|
|
Protocol string `json:"protocol,omitempty"`
|
|
MaxAudioChannels int `json:"maxAudioChannels,omitempty"`
|
|
}
|
|
|
|
// codecProfileRequest describes codec-specific limitations
|
|
type codecProfileRequest struct {
|
|
Type string `json:"type,omitempty"`
|
|
Name string `json:"name,omitempty"`
|
|
Limitations []limitationRequest `json:"limitations,omitempty"`
|
|
}
|
|
|
|
// limitationRequest describes a specific codec limitation
|
|
type limitationRequest struct {
|
|
Name string `json:"name,omitempty"`
|
|
Comparison string `json:"comparison,omitempty"`
|
|
Values []string `json:"values,omitempty"`
|
|
Required bool `json:"required,omitempty"`
|
|
}
|
|
|
|
// toCoreClientInfo converts the API request struct to the stream.ClientInfo struct.
|
|
// The OpenSubsonic spec uses bps for bitrate values; core uses kbps.
|
|
func (r *clientInfoRequest) toCoreClientInfo() *stream.ClientInfo {
|
|
ci := &stream.ClientInfo{
|
|
Name: r.Name,
|
|
Platform: r.Platform,
|
|
MaxAudioBitrate: bpsToKbps(r.MaxAudioBitrate),
|
|
MaxTranscodingAudioBitrate: bpsToKbps(r.MaxTranscodingAudioBitrate),
|
|
}
|
|
|
|
for _, dp := range r.DirectPlayProfiles {
|
|
ci.DirectPlayProfiles = append(ci.DirectPlayProfiles, stream.DirectPlayProfile{
|
|
Containers: dp.Containers,
|
|
AudioCodecs: dp.AudioCodecs,
|
|
Protocols: dp.Protocols,
|
|
MaxAudioChannels: dp.MaxAudioChannels,
|
|
})
|
|
}
|
|
|
|
for _, tp := range r.TranscodingProfiles {
|
|
ci.TranscodingProfiles = append(ci.TranscodingProfiles, stream.Profile{
|
|
Container: tp.Container,
|
|
AudioCodec: tp.AudioCodec,
|
|
Protocol: tp.Protocol,
|
|
MaxAudioChannels: tp.MaxAudioChannels,
|
|
})
|
|
}
|
|
|
|
for _, cp := range r.CodecProfiles {
|
|
coreCP := stream.CodecProfile{
|
|
Type: cp.Type,
|
|
Name: cp.Name,
|
|
}
|
|
for _, lim := range cp.Limitations {
|
|
coreLim := stream.Limitation{
|
|
Name: lim.Name,
|
|
Comparison: lim.Comparison,
|
|
Values: lim.Values,
|
|
Required: lim.Required,
|
|
}
|
|
// Convert audioBitrate limitation values from bps to kbps
|
|
if lim.Name == stream.LimitationAudioBitrate {
|
|
coreLim.Values = convertBitrateValues(lim.Values)
|
|
}
|
|
coreCP.Limitations = append(coreCP.Limitations, coreLim)
|
|
}
|
|
ci.CodecProfiles = append(ci.CodecProfiles, coreCP)
|
|
}
|
|
|
|
return ci
|
|
}
|
|
|
|
// bpsToKbps converts bits per second to kilobits per second (rounded).
|
|
func bpsToKbps(bps int) int {
|
|
if bps < 0 {
|
|
return 0
|
|
}
|
|
return (bps + 500) / 1000
|
|
}
|
|
|
|
// kbpsToBps converts kilobits per second to bits per second.
|
|
func kbpsToBps(kbps int) int {
|
|
return kbps * 1000
|
|
}
|
|
|
|
// convertBitrateValues converts a slice of bps string values to kbps string values.
|
|
func convertBitrateValues(bpsValues []string) []string {
|
|
result := make([]string, len(bpsValues))
|
|
for i, v := range bpsValues {
|
|
n, err := strconv.Atoi(v)
|
|
if err == nil {
|
|
result[i] = strconv.Itoa(bpsToKbps(n))
|
|
} else {
|
|
result[i] = v // preserve unparseable values as-is
|
|
}
|
|
}
|
|
return result
|
|
}
|
|
|
|
// validate checks that all enum fields in the request contain valid values per the OpenSubsonic spec.
|
|
func (r *clientInfoRequest) validate() error {
|
|
for _, dp := range r.DirectPlayProfiles {
|
|
for _, p := range dp.Protocols {
|
|
if !isValidProtocol(p) {
|
|
return fmt.Errorf("invalid protocol: %s", p)
|
|
}
|
|
}
|
|
}
|
|
for _, tp := range r.TranscodingProfiles {
|
|
if tp.Protocol != "" && !isValidProtocol(tp.Protocol) {
|
|
return fmt.Errorf("invalid protocol: %s", tp.Protocol)
|
|
}
|
|
}
|
|
for _, cp := range r.CodecProfiles {
|
|
if !isValidCodecProfileType(cp.Type) {
|
|
return fmt.Errorf("invalid codec profile type: %s", cp.Type)
|
|
}
|
|
for _, lim := range cp.Limitations {
|
|
if !isValidLimitationName(lim.Name) {
|
|
return fmt.Errorf("invalid limitation name: %s", lim.Name)
|
|
}
|
|
if !isValidComparison(lim.Comparison) {
|
|
return fmt.Errorf("invalid comparison: %s", lim.Comparison)
|
|
}
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Only support songs for now
|
|
var validMediaTypes = []string{
|
|
"song",
|
|
}
|
|
|
|
func isValidMediaType(mediaType string) bool {
|
|
return slices.Contains(validMediaTypes, mediaType)
|
|
}
|
|
|
|
var validProtocols = []string{
|
|
stream.ProtocolHTTP,
|
|
stream.ProtocolHLS,
|
|
}
|
|
|
|
func isValidProtocol(p string) bool {
|
|
return slices.Contains(validProtocols, p)
|
|
}
|
|
|
|
var validCodecProfileTypes = []string{
|
|
stream.CodecProfileTypeAudio,
|
|
}
|
|
|
|
func isValidCodecProfileType(t string) bool {
|
|
return slices.Contains(validCodecProfileTypes, t)
|
|
}
|
|
|
|
var validLimitationNames = []string{
|
|
stream.LimitationAudioChannels,
|
|
stream.LimitationAudioBitrate,
|
|
stream.LimitationAudioProfile,
|
|
stream.LimitationAudioSamplerate,
|
|
stream.LimitationAudioBitdepth,
|
|
}
|
|
|
|
func isValidLimitationName(n string) bool {
|
|
return slices.Contains(validLimitationNames, n)
|
|
}
|
|
|
|
var validComparisons = []string{
|
|
stream.ComparisonEquals,
|
|
stream.ComparisonNotEquals,
|
|
stream.ComparisonLessThanEqual,
|
|
stream.ComparisonGreaterThanEqual,
|
|
}
|
|
|
|
func isValidComparison(c string) bool {
|
|
return slices.Contains(validComparisons, c)
|
|
}
|
|
|
|
// toResponseStreamDetails converts a core StreamDetails to the API response type.
|
|
func toResponseStreamDetails(sd *stream.Details) *responses.StreamDetails {
|
|
return &responses.StreamDetails{
|
|
Protocol: stream.ProtocolHTTP, // TODO: derive from decision when HLS support is added
|
|
Container: sd.Container,
|
|
Codec: sd.Codec,
|
|
AudioBitrate: int32(kbpsToBps(sd.Bitrate)),
|
|
AudioProfile: sd.Profile,
|
|
AudioSamplerate: int32(sd.SampleRate),
|
|
AudioBitdepth: int32(sd.BitDepth),
|
|
AudioChannels: int32(sd.Channels),
|
|
}
|
|
}
|
|
|
|
// GetTranscodeDecision handles the OpenSubsonic getTranscodeDecision endpoint.
|
|
// It receives client capabilities and returns a decision on whether to direct play or stream.
|
|
func (api *Router) GetTranscodeDecision(w http.ResponseWriter, r *http.Request) (*responses.Subsonic, error) {
|
|
if r.Method != http.MethodPost {
|
|
w.Header().Set("Allow", "POST")
|
|
http.Error(w, "Method Not Allowed", http.StatusMethodNotAllowed)
|
|
return nil, nil
|
|
}
|
|
|
|
ctx := r.Context()
|
|
p := req.Params(r)
|
|
|
|
mediaID, err := p.String("mediaId")
|
|
if err != nil {
|
|
return nil, newError(responses.ErrorMissingParameter, "missing required parameter: mediaId")
|
|
}
|
|
|
|
mediaType, err := p.String("mediaType")
|
|
if err != nil {
|
|
return nil, newError(responses.ErrorMissingParameter, "missing required parameter: mediaType")
|
|
}
|
|
|
|
if !isValidMediaType(mediaType) {
|
|
return nil, newError(responses.ErrorGeneric, "mediaType '%s' is not yet supported", mediaType)
|
|
}
|
|
|
|
// Parse and validate ClientInfo from request body (required per OpenSubsonic spec)
|
|
var clientInfoReq clientInfoRequest
|
|
r.Body = http.MaxBytesReader(w, r.Body, 1<<20) // 1 MB limit
|
|
if err := json.NewDecoder(r.Body).Decode(&clientInfoReq); err != nil {
|
|
return nil, newError(responses.ErrorGeneric, "invalid JSON request body")
|
|
}
|
|
if err := clientInfoReq.validate(); err != nil {
|
|
return nil, newError(responses.ErrorGeneric, "%v", err)
|
|
}
|
|
clientInfo := clientInfoReq.toCoreClientInfo()
|
|
|
|
// TODO: Remove this filter once AAC transcoding works reliably
|
|
// with streaming clients (Sonos, etc).
|
|
// See https://github.com/navidrome/navidrome/discussions/4832#discussioncomment-16068231
|
|
clientInfo.TranscodingProfiles = slices.DeleteFunc(clientInfo.TranscodingProfiles, func(p stream.Profile) bool {
|
|
if p.AudioCodec != "" {
|
|
return stream.IsAACCodec(p.AudioCodec)
|
|
}
|
|
return stream.IsAACCodec(p.Container)
|
|
})
|
|
|
|
// Get media file
|
|
mf, err := api.ds.MediaFile(ctx).Get(mediaID)
|
|
if err != nil {
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
return nil, newError(responses.ErrorDataNotFound, "media file not found: %s", mediaID)
|
|
}
|
|
log.Error(ctx, "Error retrieving media file", "mediaID", mediaID, err)
|
|
return nil, newError(responses.ErrorGeneric, "error retrieving media file")
|
|
}
|
|
|
|
// Make the decision
|
|
decision, err := api.transcodeDecision.MakeDecision(ctx, mf, clientInfo, stream.TranscodeOptions{})
|
|
if err != nil {
|
|
log.Error(ctx, "Failed to make transcode decision", "mediaID", mediaID, err)
|
|
return nil, newError(responses.ErrorGeneric, "failed to make transcode decision")
|
|
}
|
|
|
|
// Only create a token when there is a valid playback path
|
|
var transcodeParams string
|
|
if decision.CanDirectPlay || decision.CanTranscode {
|
|
transcodeParams, err = api.transcodeDecision.CreateTranscodeParams(decision)
|
|
if err != nil {
|
|
log.Error(ctx, "Failed to create transcode token", "mediaID", mediaID, err)
|
|
return nil, newError(responses.ErrorGeneric, "failed to create transcode token")
|
|
}
|
|
}
|
|
|
|
// Build response (convert kbps from core to bps for the API)
|
|
response := newResponse()
|
|
response.TranscodeDecision = &responses.TranscodeDecision{
|
|
CanDirectPlay: decision.CanDirectPlay,
|
|
CanTranscode: decision.CanTranscode,
|
|
TranscodeReasons: decision.TranscodeReasons,
|
|
ErrorReason: decision.ErrorReason,
|
|
TranscodeParams: transcodeParams,
|
|
SourceStream: toResponseStreamDetails(&decision.SourceStream),
|
|
}
|
|
|
|
if decision.TranscodeStream != nil {
|
|
response.TranscodeDecision.TranscodeStream = toResponseStreamDetails(decision.TranscodeStream)
|
|
}
|
|
|
|
return response, nil
|
|
}
|
|
|
|
// GetTranscodeStream handles the OpenSubsonic getTranscodeStream endpoint.
|
|
// It streams media using the decision encoded in the transcodeParams JWT token.
|
|
// All errors are returned as proper HTTP status codes (not Subsonic error responses).
|
|
func (api *Router) GetTranscodeStream(w http.ResponseWriter, r *http.Request) (*responses.Subsonic, error) {
|
|
ctx := r.Context()
|
|
p := req.Params(r)
|
|
|
|
mediaID, err := p.String("mediaId")
|
|
if err != nil {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
mediaType, err := p.String("mediaType")
|
|
if err != nil {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
transcodeParamsToken, err := p.String("transcodeParams")
|
|
if err != nil {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
if !isValidMediaType(mediaType) {
|
|
http.Error(w, "Bad Request", http.StatusBadRequest)
|
|
return nil, nil
|
|
}
|
|
|
|
// Fetch the media file
|
|
mf, err := api.ds.MediaFile(ctx).Get(mediaID)
|
|
if err != nil {
|
|
if errors.Is(err, model.ErrNotFound) {
|
|
http.Error(w, "Not Found", http.StatusNotFound)
|
|
} else {
|
|
log.Error(ctx, "Error retrieving media file", "mediaID", mediaID, err)
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
// Validate the token and resolve streaming parameters
|
|
streamReq, err := api.transcodeDecision.ResolveRequestFromToken(ctx, transcodeParamsToken, mf, p.IntOr("offset", 0))
|
|
if err != nil {
|
|
switch {
|
|
case errors.Is(err, stream.ErrTokenInvalid), errors.Is(err, stream.ErrTokenStale):
|
|
http.Error(w, "Gone", http.StatusGone)
|
|
default:
|
|
log.Error(ctx, "Error validating transcode params", err)
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
// Create stream
|
|
stream, err := api.streamer.NewStream(ctx, mf, streamReq)
|
|
if err != nil {
|
|
log.Error(ctx, "Error creating stream", "mediaID", mediaID, err)
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
return nil, nil
|
|
}
|
|
|
|
// Make sure the stream will be closed at the end
|
|
defer func() {
|
|
if err := stream.Close(); err != nil && log.IsGreaterOrEqualTo(log.LevelDebug) {
|
|
log.Error("Error closing stream", "id", mediaID, "file", stream.Name(), err)
|
|
}
|
|
}()
|
|
|
|
w.Header().Set("X-Content-Type-Options", "nosniff")
|
|
|
|
n, err := stream.Serve(ctx, w, r)
|
|
if err != nil || n == 0 {
|
|
http.Error(w, "Internal Server Error", http.StatusInternalServerError)
|
|
}
|
|
return nil, nil
|
|
}
|