mirror of
https://github.com/navidrome/navidrome.git
synced 2026-02-23 18:38:34 -05:00
* fix(subsonic): optimize search3 for high-cardinality FTS queries Use a two-phase query strategy for FTS5 searches to avoid the performance penalty of expensive LEFT JOINs (annotation, bookmark, library) on high-cardinality results like "the". Phase 1 runs a lightweight query (main table + FTS index only) to get sorted, paginated rowids. Phase 2 hydrates only those few rowids with the full JOINs, making them nearly free. For queries with complex ORDER BY expressions that reference joined tables (e.g. artist search sorted by play count), the optimization is skipped and the original single-query approach is used. * fix(search): update order by clauses to include 'rank' for FTS queries Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): reintroduce 'rank' in Phase 2 ORDER BY for FTS queries Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): remove 'rank' from ORDER BY in non-FTS queries and adjust two-phase query handling Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): update FTS ranking to use bm25 weights and simplify ORDER BY qualification Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): refine FTS query handling and improve comments for clarity Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): refactor full-text search handling to streamline query strategy selection and improve LIKE fallback logic. Increase e2e coverage for search3 Signed-off-by: Deluan <deluan@navidrome.org> * refactor: enhance FTS column definitions and relevance weights Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): refactor Search method signatures to remove offset and size parameters, streamline query handling Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): allow single-character queries in search strategies and update related tests Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): make FTS Phase 1 treat Max=0 as no limit, reorganize tests FTS Phase 1 unconditionally called Limit(uint64(options.Max)), which produced LIMIT 0 when Max was zero. This diverged from applyOptions where Max=0 means no limit. Now Phase 1 mirrors applyOptions: only add LIMIT/OFFSET when the value is positive. Also moved legacy backend integration tests from sql_search_fts_test.go to sql_search_like_test.go and added regression tests for the Max=0 behavior on both backends. * refactor: simplify callSearch function by removing variadic options and directly using QueryOptions Signed-off-by: Deluan <deluan@navidrome.org> * fix(search): implement ftsQueryDegraded function to detect significant content loss in FTS queries Signed-off-by: Deluan <deluan@navidrome.org> --------- Signed-off-by: Deluan <deluan@navidrome.org>
113 lines
3.7 KiB
Go
113 lines
3.7 KiB
Go
package persistence
|
|
|
|
import (
|
|
"github.com/navidrome/navidrome/conf"
|
|
"github.com/navidrome/navidrome/conf/configtest"
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
)
|
|
|
|
var _ = Describe("sqlRepository", func() {
|
|
Describe("formatFullText", func() {
|
|
It("prefixes with a space", func() {
|
|
Expect(formatFullText("legiao urbana")).To(Equal(" legiao urbana"))
|
|
})
|
|
})
|
|
|
|
Describe("getSearchStrategy", func() {
|
|
It("returns FTS strategy by default", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "fts"
|
|
conf.Server.Search.FullString = false
|
|
|
|
strategy := getSearchStrategy("media_file", "test")
|
|
Expect(strategy).ToNot(BeNil())
|
|
sql, _, err := strategy.ToSql()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(sql).To(ContainSubstring("MATCH"))
|
|
})
|
|
|
|
It("returns legacy LIKE strategy when SearchBackend is legacy", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "legacy"
|
|
conf.Server.Search.FullString = false
|
|
|
|
strategy := getSearchStrategy("media_file", "test")
|
|
Expect(strategy).ToNot(BeNil())
|
|
sql, _, err := strategy.ToSql()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(sql).To(ContainSubstring("LIKE"))
|
|
})
|
|
|
|
It("falls back to legacy LIKE strategy when SearchFullString is enabled", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "fts"
|
|
conf.Server.Search.FullString = true
|
|
|
|
strategy := getSearchStrategy("media_file", "test")
|
|
Expect(strategy).ToNot(BeNil())
|
|
sql, _, err := strategy.ToSql()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(sql).To(ContainSubstring("LIKE"))
|
|
})
|
|
|
|
It("routes CJK queries to LIKE strategy instead of FTS", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "fts"
|
|
conf.Server.Search.FullString = false
|
|
|
|
strategy := getSearchStrategy("media_file", "周杰伦")
|
|
Expect(strategy).ToNot(BeNil())
|
|
sql, _, err := strategy.ToSql()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
// CJK should use LIKE, not MATCH
|
|
Expect(sql).To(ContainSubstring("LIKE"))
|
|
Expect(sql).NotTo(ContainSubstring("MATCH"))
|
|
})
|
|
|
|
It("routes non-CJK queries to FTS strategy", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "fts"
|
|
conf.Server.Search.FullString = false
|
|
|
|
strategy := getSearchStrategy("media_file", "beatles")
|
|
Expect(strategy).ToNot(BeNil())
|
|
sql, _, err := strategy.ToSql()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
Expect(sql).To(ContainSubstring("MATCH"))
|
|
})
|
|
|
|
It("returns non-nil for single-character query (no min-length in strategy)", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "fts"
|
|
conf.Server.Search.FullString = false
|
|
|
|
strategy := getSearchStrategy("media_file", "a")
|
|
Expect(strategy).ToNot(BeNil(), "single-char queries must be accepted by strategies (min-length is enforced in doSearch)")
|
|
})
|
|
|
|
It("returns non-nil for single-character query with legacy backend", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "legacy"
|
|
conf.Server.Search.FullString = false
|
|
|
|
strategy := getSearchStrategy("media_file", "a")
|
|
Expect(strategy).ToNot(BeNil(), "single-char queries must be accepted by legacy strategy (min-length is enforced in doSearch)")
|
|
})
|
|
|
|
It("uses legacy for CJK when SearchBackend is legacy", func() {
|
|
DeferCleanup(configtest.SetupConfig())
|
|
conf.Server.Search.Backend = "legacy"
|
|
conf.Server.Search.FullString = false
|
|
|
|
strategy := getSearchStrategy("media_file", "周杰伦")
|
|
Expect(strategy).ToNot(BeNil())
|
|
sql, _, err := strategy.ToSql()
|
|
Expect(err).ToNot(HaveOccurred())
|
|
// Legacy should still use full_text column LIKE
|
|
Expect(sql).To(ContainSubstring("LIKE"))
|
|
Expect(sql).To(ContainSubstring("full_text"))
|
|
})
|
|
})
|
|
})
|