Andrey Prygunkov
c68ba306fe
#131 : using enum for file mode in function DiskFile::Open
2015-12-26 17:19:12 +01:00
Andrey Prygunkov
dce6f0c9a3
#131 : new class DiskFile to wrap "FILE*"-functions
2015-12-25 18:11:50 +01:00
Andrey Prygunkov
8fb9fb7b2d
#133 : put all par2-modules into namespace "Par2"
...
To avoid conflicts with similarly named classes of NZBGet.
2015-12-24 21:25:38 +01:00
Andrey Prygunkov
eae6fd5d91
#131 : wrapped function "remove" into module FileSystem
...
under name “DeleteFile”.
2015-12-24 18:34:15 +01:00
Andrey Prygunkov
321c7efa41
#130 : moved parts from module "Util" into new module "FileSystem"
2015-12-22 22:01:03 +01:00
Andrey Prygunkov
19ce3bf69b
#130 : improved class DirBrowser
...
It doesn’t return filenames ‘.’ and ‘..’ (for current and parent
directories) anymore, eliminating the need to check and ignore these
names on each usage of the class.
2015-12-21 20:54:21 +01:00
Andrey Prygunkov
99d8cee0db
#126 : class BString supports initialization via assignment
...
which makes the code clearer.
2015-12-20 23:46:22 +01:00
Andrey Prygunkov
d87d6ac2ac
#126 : using CString for ref-parameters and return values
...
1) for parameters use references to CString instead of pointers to
buffers;
2) when returning strings use CString instead of pointer to char buffer
which caller needs to deallocate;
3) use BString even more.
2015-12-20 16:27:01 +01:00
Andrey Prygunkov
9e2d8544da
#126 : full use of class BString
...
1) replaced characters arrays with class BString through the whole
program. The string formatting code has become much cleaner.
2) class Util returns error message via CString instead of character
buffers.
3) few more places to use CString.
2015-12-19 18:43:52 +01:00
Andrey Prygunkov
6d33d83d20
#126 : using GCC attributes to detect formatting errors
...
also eliminated warnings found with activated detection.
2015-12-13 18:28:48 +01:00
Andrey Prygunkov
558fce9b47
#126 : replaced C-style strings with class "CString"
...
: replaced all data members.
2015-12-12 16:36:25 +01:00
Andrey Prygunkov
4e4816c3c8
#116 : use size specific integer types
2015-11-21 00:02:22 +01:00
Andrey Prygunkov
ec17d119a1
#115 : put all external headers together
...
into “nzbget.h”
2015-11-19 23:51:02 +01:00
Andrey Prygunkov
70ccfd9802
normalized whitespace formatting
...
1) removed trailing spaces and tabs;
2) replaced occasional leading spaces with tabs.
2015-11-05 23:45:19 +01:00
Andrey Prygunkov
bf49f16d7c
#103 : renamed global variables
2015-11-01 21:42:35 +01:00
Andrey Prygunkov
1fb21b330e
#103 : normalized (renamed) acronyms
2015-10-30 23:54:37 +01:00
Andrey Prygunkov
5adb50274e
#103 : renamed local, member variables and function parameters
2015-10-27 22:37:23 +01:00
Andrey Prygunkov
9e493c6c4d
#64 : fixed: par-checker may not look for missing files
...
When option ParScan was set to “Dupe” the extra-files were not scanned
in current directory.
2015-09-04 23:36:40 +02:00
Andrey Prygunkov
ff8f2472a0
#64 : fixed: option ParScan=Extended didn't work
...
When option ParScan was set to “Extended” the extra-files were not
found. Bug introduced v16.
2015-09-04 20:55:49 +02:00
Andrey Prygunkov
c6656cffbf
#64 : indication of par-repair using dupe sources
...
in history details dialog:
- status “REPAIR: RECIPIENT” or “STATUS:DONOR” with hint details;
- in statistics details (via click on “Total downloaded ->”);
- new field “ExtraParBlocks” returned by API-method “history”: positive
numbers for recipient, negative numbers for donor.
2015-08-13 19:38:28 +02:00
Andrey Prygunkov
e4d62ebbc8
par-checker: do not report bad blocks for missing files
...
- do not report bad blocks for missing files (which are already
reported as missing);
- reporting of bad blocks for empty files could print garbage file
names.
2015-08-12 21:16:44 +02:00
Andrey Prygunkov
24fd4e8c15
#26 , #60 , #64 , #70 : corrected file permissions
2015-08-11 22:31:59 +02:00
Andrey Prygunkov
5b460b7512
#64 : improved progress calculation during extra par-scan
2015-08-10 19:52:27 +02:00
Andrey Prygunkov
2a9f9f8e98
#64 : implemented dupe matcher
...
Before scanning of dupe directories the directories are quickly checked
by dupe matcher. It determines if they contain or may contain the same
content. If the dupe checker detects a dupe containing different
content as the download being currently processed by par-checker, such
extra dupe is skipped to save time during dupe par scan.
2015-08-07 18:38:51 +02:00
Andrey Prygunkov
a11d22d3e0
#64 : small adjustments in debug logging
2015-08-02 16:59:49 +02:00
Andrey Prygunkov
d07b9af366
#64 : process more pars again, after dupe par-check
2015-08-02 16:59:25 +02:00
Andrey Prygunkov
941c2efb52
#64 : first use par2-files, then scan dupes
2015-08-02 01:32:59 +02:00
Andrey Prygunkov
820260cb6c
#64 : in option "ParScan" renamed mode "auto" to "extended"
...
Now having four modes: limited, extended, full and dupe.
2015-08-02 00:38:39 +02:00
Andrey Prygunkov
c674405b44
#64 : renamed value "Beyond" to "Dupe"
...
in option ParScan. The new value name suits better.
2015-08-01 01:23:34 +02:00
Andrey Prygunkov
1a206457a2
#64 : new par-scan mode "beyond"
...
- new value for option “ParScan” - “Beyond”;
- in this mode the files from other downloads (duplicates) are scanned
as well;
- this helps if both downloads contain the same file inside archive,
even if the archives were created with different split-settings and
different par-sets.
2015-07-31 21:26:14 +02:00
Andrey Prygunkov
c93c0e9dce
#41 : removed spinlocks support
2015-07-17 23:43:53 +02:00
Andrey Prygunkov
4daf01e683
fixed few compiler warnings in Windows
2015-07-13 21:13:26 +02:00
Andrey Prygunkov
734dbfc98b
refactor: changed one parameter in par2-module from "double" to "int"
2015-06-05 10:55:11 +00:00
Andrey Prygunkov
5d24697b0c
refactor: reworked declaration of global objects (singletones)
2015-05-22 20:28:05 +00:00
Andrey Prygunkov
27fd8989d8
fixed: par-verification of repaired files were sometimes not skipped in quick verification mode (option "ParQuick=yes")
2015-05-21 14:41:14 +00:00
Andrey Prygunkov
a641bd8bd1
refactor: reducing module dependencies for easier testing: extracted par file name parsing code from module "ParCoordinator" into new module "ParParser", which can be instantiated separately
2015-05-21 14:33:16 +00:00
Andrey Prygunkov
240ccdc65e
fixed: par-check in full verification mode (not in quick mode) could not detected damaged files if they were completely empty (0 bytes), which is possible when option "DirectWrite" was not active and all articles of the file were missing
2015-03-10 22:13:06 +00:00
Andrey Prygunkov
bad4c7ed34
renamed option "CreateBrokenLog" to "BrokenLog"; the old option name is recognized and automatically converted when the configuration is saved in web-interface
2015-02-27 18:43:15 +00:00
Andrey Prygunkov
7e6f8f19eb
each nzb now has its own individual log, where messages printed during download or post-processing are saved; the messages can be retrieved later at any time; new button "Log" in the history details dialog; button "Log" in the download details dialog is now active during download too (not only during post-processing); the log contains all nzb-related messages except detail-messages and errors printed during retrieving of articles (they would produce way too many messages and are not that useful anyway); new option "NzbLog" to deactivate per-nzb logging if necessary; per-nzb logs are saved in the queue-directory (option "QueueDir"); new RPC-method "loadlog" returns the previously saved messages for a given nzb-file; new field "MessageCount" is returned by RPC-methods "listgroups" and "history" and indicates if there are any messages saved for the item; parameter "NumberOfLogEntries" of RPC-method "listgroups" and the field "Log" returned by the method are now deprecated, use method "loadlag" instead; field "PostInfoText" returned by RPC-method "listgroups" is now automatically filled with the latest message printed by a pp-script eliminating the need to access deprecated field "Log"
2015-02-26 20:57:38 +00:00
Andrey Prygunkov
11bfb57809
added support for password list file; new option "UnpackPassFile" to set the location of the file; during unpack the passwords are tried from the file until unpack succeeds or all passwords were tried; implemented different strategies for rar4 and rar5-archives taking into account the features of formats; for rar5-archives a wrong password is reported by unrar unambiguously and the program can immediately try other passwords from the password list; for rar4-archives and for 7z-archives it is not possible to differentiate between damaged archive and wrong password; for those archives if the first unpack attempt (without password) fails the program executes par-check (preferably quick par-check if enabled via option "ParQuick) before trying the passwords from the list; another optimization is that the password list is tried only when the first unpack attempt (without password) reports a password error or decryption errors; this saves unnecessary unpack attempts for damaged unencrypted archives
2015-01-22 20:57:39 +00:00
Andrey Prygunkov
634247676a
fixed: quick par-check could hang on certain nzb-files containing multiple par-sets (occured only in 64 bit mode)
2014-11-14 19:38:41 +00:00
Andrey Prygunkov
9269f69a38
improvement in quick par-verification: if unpack fails (excluding invalid password errors) and quick par-check does not find any errors or quick par-check was already performed the full par-check is performed; this helps in rare situations when files were correctly downloaded (and therefore assumed correct by quick par-check) but incorrectly written into disk due to abnormal program termination (caused by bugs or hardware crashes)
2014-10-09 21:11:42 +00:00
Andrey Prygunkov
6f7af5aef4
option "ParThreads" can now be set to "0" (which is a default setting now) to let the program automatically determine the number of CPU cores; this works on major modern platforms)
2014-10-04 19:34:03 +00:00
Andrey Prygunkov
d0754e022f
addition to r1121: now fixed on windows too: inner files (files listed in nzb) bigger than 2GB could not be downloaded
2014-09-08 19:35:11 +00:00
Andrey Prygunkov
96e8cbd3c1
small improvement in multithreading par-repair: the number of repair threads is now automatically reduced to the amount of bad blocks if there are too few of them; if there is only one bad block the multithreading par-repair is switched off to avoid overhead of thread synchronisation (which does not make sense for one working thread)
2014-09-03 17:34:36 +00:00
Andrey Prygunkov
658d41f0fd
refactor: moved nzbget specific code from libpar2 into nzbget units in order to make updates of libpar2 easier in the future
2014-09-03 17:28:29 +00:00
Andrey Prygunkov
9dab8fd7dc
added multithreading par-repair: does not depend on other libraries and works on all platforms and all CPUs (with multiple cores); new option "ParThreads" to set the number of threads for repairing; new option "ParBuffer" to define the memory limit to use during par-repair
2014-09-02 23:07:32 +00:00
Andrey Prygunkov
44907aa700
when quick par verification is active the repaired files are not verified to save time; the only reason for incorrect files after repair can be hardware errors (memory, disk) but this is not something NZBGet should care about
2014-08-22 17:24:34 +00:00
Andrey Prygunkov
54303d464b
fixed: one log-message was printed only to global log but not to nzb-item pp-log
2014-08-22 17:05:30 +00:00
Andrey Prygunkov
008768cea1
better error reporting during par-check
2014-08-20 18:51:13 +00:00
