From 01e68ca6adf13286661aa1813b709c2145cecd71 Mon Sep 17 00:00:00 2001
From: jcm <6864788+jcm93@users.noreply.github.com>
Date: Fri, 17 Jul 2026 17:07:57 -0600
Subject: [PATCH] frontend: Fix deprecated header order in Add Source dialog

---
 frontend/dialogs/OBSBasicSourceSelect.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/frontend/dialogs/OBSBasicSourceSelect.cpp b/frontend/dialogs/OBSBasicSourceSelect.cpp
index d7aece644..18efb87ce 100644
--- a/frontend/dialogs/OBSBasicSourceSelect.cpp
+++ b/frontend/dialogs/OBSBasicSourceSelect.cpp
@@ -546,10 +546,10 @@ void OBSBasicSourceSelect::rebuildSourceTypeList()
 
 	// Shift Deprecated sources to the bottom
 	QList<QListWidgetItem *> deprecatedItems;
-	for (int i = 0; i < ui->sourceTypeList->count(); ++i) {
+	for (int i = ui->sourceTypeList->count() - 1; i >= 0; --i) {
 		QListWidgetItem *item = ui->sourceTypeList->item(i);
 		if (!item) {
-			break;
+			continue;
 		}
 
 		bool isDeprecated = item->data(kDeprecatedRole).toBool();
@@ -562,6 +562,7 @@ void OBSBasicSourceSelect::rebuildSourceTypeList()
 		}
 	}
 
+	std::reverse(deprecatedItems.begin(), deprecatedItems.end());
 	for (const auto &item : deprecatedItems) {
 		ui->sourceTypeList->addItem(item);
 	}