mirror/obs-studio
1
0
Fork 0
mirror of https://github.com/obsproject/obs-studio.git synced 2026-07-12 08:19:13 -04:00
Code Issues Packages Projects Releases Wiki Activity

frontend: Use Qt parent-child ownership in OAuth dialog

Browse Source 
By explicitly setting the OAuth dialog as the parent of the CEF widget,
it will automatically by cleaned up as soon as the dialog is closed
itself.

This also detaches the destruction of the widget from the browser
cleanup code.
This commit is contained in:
PatTheMav
2025-10-09 17:23:11 +02:00
committed by Patrick Heyer
parent 0b12296320
commit 13ba51a9ad
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/dialogs/OAuthLogin.cpp
View File

@@ -31,7 +31,7 @@ OAuthLogin::OAuthLogin(QWidget *parent, const std::string &url, bool token) : QD
OBSBasic::InitBrowserPanelSafeBlock();
cefWidget = cef->create_widget(nullptr, url, panel_cookies);
cefWidget = cef->create_widget(this, url, panel_cookies);
if (!cefWidget) {
fail = true;
return;
@@ -71,7 +71,9 @@ int OAuthLogin::exec()
void OAuthLogin::reject()
{
#ifdef BROWSER_AVAILABLE
delete cefWidget;
if (cefWidget) {
cefWidget->closeBrowser();
}
#endif
QDialog::reject();
}
@@ -79,7 +81,9 @@ void OAuthLogin::reject()
void OAuthLogin::accept()
{
#ifdef BROWSER_AVAILABLE
delete cefWidget;
if (cefWidget) {
cefWidget->closeBrowser();
}
#endif
QDialog::accept();
}