From 17fc299b74ed8eeda7dcb5bcd0fce068ab2200da Mon Sep 17 00:00:00 2001 From: tfo Date: Tue, 17 Feb 2026 22:14:55 +0100 Subject: [PATCH] win-dshow: Fix CreateFileW return value check in virtualcam filter CreateFileW returns INVALID_HANDLE_VALUE on failure, not NULL. The previous check would always evaluate to true on failure, causing ReadFile and CloseHandle to be called on an invalid handle. --- plugins/win-dshow/virtualcam-module/virtualcam-filter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/win-dshow/virtualcam-module/virtualcam-filter.cpp b/plugins/win-dshow/virtualcam-module/virtualcam-filter.cpp index 89702b357..7d96416b4 100644 --- a/plugins/win-dshow/virtualcam-module/virtualcam-filter.cpp +++ b/plugins/win-dshow/virtualcam-module/virtualcam-filter.cpp @@ -61,7 +61,7 @@ VCamFilter::VCamFilter() : OutputFilter() StringCbCat(res_file, sizeof(res_file), L"\\obs-virtualcam.txt"); HANDLE file = CreateFileW(res_file, GENERIC_READ, 0, nullptr, OPEN_EXISTING, 0, nullptr); - if (file) { + if (file != INVALID_HANDLE_VALUE) { char res[128]; DWORD len = 0;