From 5191622d211d82eca1800310642f1256c70fcec4 Mon Sep 17 00:00:00 2001 From: jp9000 Date: Sun, 10 Apr 2016 22:55:23 -0700 Subject: [PATCH] UI: Fix bug where bitrate limits wouldn't be shown Bitrate limit warnings wouldn't be correctly shown if service settings are changed but not yet saved before modifying the bitrates/settings. It would use the currently active service settings instead of the changed values. --- obs/window-basic-settings.cpp | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/obs/window-basic-settings.cpp b/obs/window-basic-settings.cpp index bacf3796d..e3783da42 100644 --- a/obs/window-basic-settings.cpp +++ b/obs/window-basic-settings.cpp @@ -480,6 +480,8 @@ OBSBasicSettings::OBSBasicSettings(QWidget *parent) this, SLOT(SimpleRecordingEncoderChanged())); connect(ui->simpleOutEnforce, SIGNAL(toggled(bool)), this, SLOT(SimpleRecordingEncoderChanged())); + connect(ui->listWidget, SIGNAL(currentRowChanged(int)), + this, SLOT(SimpleRecordingEncoderChanged())); LoadSettings(false); @@ -3063,7 +3065,17 @@ void OBSBasicSettings::SimpleRecordingEncoderChanged() QString warning; bool advanced = ui->simpleOutAdvanced->isChecked(); bool enforceBitrate = ui->simpleOutEnforce->isChecked() || !advanced; - obs_service_t *service = main->GetService(); + OBSService service; + + if (stream1Changed) { + QString streamType = GetComboData(ui->streamType); + service = obs_service_create_private( + QT_TO_UTF8(streamType), nullptr, + streamProperties->GetSettings()); + obs_service_release(service); + } else { + service = main->GetService(); + } delete simpleOutRecWarning;