From 747f67e150d45e6da0a67ae4457e37461ef283aa Mon Sep 17 00:00:00 2001 From: tytan652 Date: Sat, 30 Aug 2025 12:58:12 +0200 Subject: [PATCH] frontend: Do not enable crash log upload without log file Co-authored-by: PatTheMav --- frontend/utility/CrashHandler.cpp | 8 ++++++++ frontend/utility/CrashHandler.hpp | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/frontend/utility/CrashHandler.cpp b/frontend/utility/CrashHandler.cpp index d4281bd43..8b8cb9243 100644 --- a/frontend/utility/CrashHandler.cpp +++ b/frontend/utility/CrashHandler.cpp @@ -141,6 +141,10 @@ bool CrashHandler::hasNewCrashLog() { CrashLogUpdateResult result = updateLocalCrashLogState(); + if (result == CrashLogUpdateResult::NotAvailable) { + return false; + } + bool hasNewCrashLog = (result == CrashLogUpdateResult::Updated); bool hasNoLogUrl = lastCrashLogURL_.empty(); @@ -153,6 +157,10 @@ CrashLogUpdateResult CrashHandler::updateLocalCrashLogState() std::filesystem::path lastLocalCrashLogFile = findLastCrashLog(); + if (lastLocalCrashLogFile.empty() && lastCrashLogFile_.empty()) { + return CrashLogUpdateResult::NotAvailable; + } + if (lastLocalCrashLogFile != lastCrashLogFile_) { lastCrashLogFile_ = std::move(lastLocalCrashLogFile); lastCrashLogFileName_ = lastCrashLogFile_.filename().u8string(); diff --git a/frontend/utility/CrashHandler.hpp b/frontend/utility/CrashHandler.hpp index 2d98ab765..b7fa93046 100644 --- a/frontend/utility/CrashHandler.hpp +++ b/frontend/utility/CrashHandler.hpp @@ -67,7 +67,7 @@ public: std::filesystem::path getCrashLogDirectory() const; void uploadLastCrashLog(); - enum class CrashLogUpdateResult { InvalidResult, NotUpdated, Updated }; + enum class CrashLogUpdateResult { InvalidResult, NotAvailable, NotUpdated, Updated }; private: void checkCrashState();