From 7cd4e7de34b02f34e10f74db132e3034d2ff2da4 Mon Sep 17 00:00:00 2001 From: Ryan Foster Date: Mon, 22 Jun 2026 16:12:16 -0400 Subject: [PATCH] CI: Install NSIS in the windows-patches action The windows-2022 runner had NSIS pre-installed. The windows-2025 runners are slimmer and do not have NSIS installed. The windows-2025 runners do have winget available, which can be used to install NSIS. The windows-2025 runners do not have NSIS in PATH by default, so we need to specify it manually in the config files. Follow-up to ac19ea663375cd02997be92b7d8ff6dd89a511ad. --- .github/actions/windows-patches/action.yaml | 6 ++++++ .github/actions/windows-patches/config.toml | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/actions/windows-patches/action.yaml b/.github/actions/windows-patches/action.yaml index e55c59ffc..61b82134a 100644 --- a/.github/actions/windows-patches/action.yaml +++ b/.github/actions/windows-patches/action.yaml @@ -68,6 +68,12 @@ runs: Expand-Archive -Path $windows_zip -DestinationPath bin Expand-Archive -Path $nsis_zip -DestinationPath nsis + - name: Install NSIS + shell: pwsh + run: | + # Install NSIS + winget install --silent --accept-package-agreements --accept-source-agreements --disable-interactivity -e --id NSIS.NSIS + - name: Install rclone and pandoc shell: pwsh run: | diff --git a/.github/actions/windows-patches/config.toml b/.github/actions/windows-patches/config.toml index 2382fbfea..6c1af9f66 100644 --- a/.github/actions/windows-patches/config.toml +++ b/.github/actions/windows-patches/config.toml @@ -4,7 +4,7 @@ log_level = "trace" [env] # On CI these should be in %PATH% sevenzip_path = "7z" -makensis_path = "makensis" +makensis_path = "C:/Program Files (x86)/NSIS/makensis.exe" pandoc_path = "pandoc" pdbcopy_path = "C:/Program Files (x86)/Windows Kits/10/Debuggers/x64/pdbcopy.exe"