From 84361415ff7a164be4dfbb9780dc677b3ec7bb08 Mon Sep 17 00:00:00 2001 From: Warchamp7 Date: Mon, 26 Jan 2026 15:39:38 -0500 Subject: [PATCH] frontend: Close rename dialog if name unchanged --- frontend/components/VolumeControl.cpp | 4 ++++ frontend/widgets/OBSBasic_Transitions.cpp | 8 +++++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/frontend/components/VolumeControl.cpp b/frontend/components/VolumeControl.cpp index dc1953cad..e27def77b 100644 --- a/frontend/components/VolumeControl.cpp +++ b/frontend/components/VolumeControl.cpp @@ -491,6 +491,10 @@ void VolumeControl::renameSource() continue; } + if (name == prevName) { + return; + } + OBSSourceAutoRelease sourceTest = obs_get_source_by_name(name.c_str()); if (sourceTest) { diff --git a/frontend/widgets/OBSBasic_Transitions.cpp b/frontend/widgets/OBSBasic_Transitions.cpp index ed2a9c19b..235f4e7b8 100644 --- a/frontend/widgets/OBSBasic_Transitions.cpp +++ b/frontend/widgets/OBSBasic_Transitions.cpp @@ -562,14 +562,20 @@ void OBSBasic::RenameTransition(OBSSource transition) bool accepted = NameDialog::AskForName(this, QTStr("TransitionNameDlg.Title"), QTStr("TransitionNameDlg.Text"), name, placeHolderText); - if (!accepted) + if (!accepted) { return; + } + if (name.empty()) { OBSMessageBox::warning(this, QTStr("NoNameEntered.Title"), QTStr("NoNameEntered.Text")); RenameTransition(transition); return; } + if (name == oldName) { + return; + } + source = FindTransition(name.c_str()); if (source) { OBSMessageBox::warning(this, QTStr("NameExists.Title"), QTStr("NameExists.Text"));