From ac19ea663375cd02997be92b7d8ff6dd89a511ad Mon Sep 17 00:00:00 2001 From: Ryan Foster Date: Sat, 20 Jun 2026 23:53:00 -0400 Subject: [PATCH] CI: Install NSIS in the windows-signing action The windows-2022 runner had NSIS pre-installed. The windows-2025 runners are slimmer and do not have NSIS installed. The windows-2025 runners do have winget available, which can be used to install NSIS. The windows-2025 runners do not have NSIS in PATH by default, so we need to specify it manually in the config files. --- .github/actions/windows-signing/action.yaml | 6 ++++++ .github/actions/windows-signing/config_arm64.toml | 2 +- .github/actions/windows-signing/config_x64.toml | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/.github/actions/windows-signing/action.yaml b/.github/actions/windows-signing/action.yaml index 8f6db3d03..1cd5564e2 100644 --- a/.github/actions/windows-signing/action.yaml +++ b/.github/actions/windows-signing/action.yaml @@ -54,6 +54,12 @@ runs: Expand-Archive -Path $windows_zip -DestinationPath bin Expand-Archive -Path $nsis_zip -DestinationPath nsis + - name: Install NSIS + shell: pwsh + run: | + # Install NSIS + winget install --silent --accept-package-agreements --accept-source-agreements --disable-interactivity -e --id NSIS.NSIS + - name: Setup Google CNG Provider shell: pwsh env: diff --git a/.github/actions/windows-signing/config_arm64.toml b/.github/actions/windows-signing/config_arm64.toml index fb4b3263d..604462426 100644 --- a/.github/actions/windows-signing/config_arm64.toml +++ b/.github/actions/windows-signing/config_arm64.toml @@ -4,7 +4,7 @@ log_level = "trace" [env] # On CI these should be in %PATH% sevenzip_path = "7z" -makensis_path = "makensis" +makensis_path = "C:/Program Files (x86)/NSIS/makensis.exe" pandoc_path = "pandoc" pdbcopy_path = "C:/Program Files (x86)/Windows Kits/10/Debuggers/x64/pdbcopy.exe" diff --git a/.github/actions/windows-signing/config_x64.toml b/.github/actions/windows-signing/config_x64.toml index f0b5bb9f8..892879131 100644 --- a/.github/actions/windows-signing/config_x64.toml +++ b/.github/actions/windows-signing/config_x64.toml @@ -4,7 +4,7 @@ log_level = "trace" [env] # On CI these should be in %PATH% sevenzip_path = "7z" -makensis_path = "makensis" +makensis_path = "C:/Program Files (x86)/NSIS/makensis.exe" pandoc_path = "pandoc" pdbcopy_path = "C:/Program Files (x86)/Windows Kits/10/Debuggers/x64/pdbcopy.exe"