From b686c971adf95dc0ffadd7a59a592bfa5f26667c Mon Sep 17 00:00:00 2001 From: derrod Date: Mon, 20 Mar 2023 14:18:39 +0100 Subject: [PATCH] UI: Remove ProRes Warning --- UI/data/locale/en-US.ini | 1 - UI/window-basic-settings.cpp | 48 +++++++----------------------------- 2 files changed, 9 insertions(+), 40 deletions(-) diff --git a/UI/data/locale/en-US.ini b/UI/data/locale/en-US.ini index 806a073c7..53a87af16 100644 --- a/UI/data/locale/en-US.ini +++ b/UI/data/locale/en-US.ini @@ -1324,7 +1324,6 @@ SceneItemHide="Hide '%1'" # Output warnings OutputWarnings.NoTracksSelected="You must select at least one track" OutputWarnings.MP4Recording="Warning: Recordings saved to MP4/MOV will be unrecoverable if the file cannot be finalized (e.g. as a result of BSODs, power losses, etc.). If you want to record multiple audio tracks consider using MKV and remux the recording to MP4/MOV after it is finished (File → Remux Recordings)" -OutputWarnings.ProResRecording="Apple ProRes is not supported by the %1 container format - supported container formats are mov (preferred) and mkv." OutputWarnings.CannotPause="Warning: Recordings cannot be paused if the recording encoder is set to \"(Use stream encoder)\"" # deleting final scene diff --git a/UI/window-basic-settings.cpp b/UI/window-basic-settings.cpp index e4fb8964e..e97c05317 100644 --- a/UI/window-basic-settings.cpp +++ b/UI/window-basic-settings.cpp @@ -4919,47 +4919,17 @@ void OBSBasicSettings::AdvOutRecCheckWarnings() errorMsg = QTStr("OutputWarnings.NoTracksSelected"); } - QString recEncoder = ui->advOutRecEncoder->currentText(); + if (recFormat == "mp4" || recFormat == "mov") { + if (!warningMsg.isEmpty()) + warningMsg += "\n\n"; - if (recEncoder.contains("ProRes")) { - if (recFormat == "mkv") { - ui->autoRemux->setText( - QTStr("Basic.Settings.Advanced.AutoRemux") - .arg("mov")); - } else if (recFormat == "mov") { - if (!warningMsg.isEmpty()) - warningMsg += "\n\n"; - warningMsg += QTStr("OutputWarnings.MP4Recording"); - - ui->autoRemux->setText( - QTStr("Basic.Settings.Advanced.AutoRemux") - .arg("mov") + - " " + - QTStr("Basic.Settings.Advanced.AutoRemux.MP4")); - } else { - if (!errorMsg.isEmpty()) { - errorMsg += "\n\n"; - } - - errorMsg += QTStr("OutputWarnings.ProResRecording") - .arg(recFormat); - } + warningMsg += QTStr("OutputWarnings.MP4Recording"); + ui->autoRemux->setText( + QTStr("Basic.Settings.Advanced.AutoRemux").arg("mp4") + + " " + QTStr("Basic.Settings.Advanced.AutoRemux.MP4")); } else { - if (recFormat == "mp4" || recFormat == "mov") { - if (!warningMsg.isEmpty()) - warningMsg += "\n\n"; - - warningMsg += QTStr("OutputWarnings.MP4Recording"); - ui->autoRemux->setText( - QTStr("Basic.Settings.Advanced.AutoRemux") - .arg("mp4") + - " " + - QTStr("Basic.Settings.Advanced.AutoRemux.MP4")); - } else { - ui->autoRemux->setText( - QTStr("Basic.Settings.Advanced.AutoRemux") - .arg("mp4")); - } + ui->autoRemux->setText( + QTStr("Basic.Settings.Advanced.AutoRemux").arg("mp4")); } delete advOutRecWarning;