From b7e2247de2dabb5ad2da24735e267872bc77ebf5 Mon Sep 17 00:00:00 2001 From: jp9000 Date: Thu, 15 Mar 2018 12:11:46 -0700 Subject: [PATCH] UI/updater: Return false on integrity check failure --- UI/win-update/updater/updater.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/UI/win-update/updater/updater.cpp b/UI/win-update/updater/updater.cpp index 5f1d72f01..15fadab4b 100644 --- a/UI/win-update/updater/updater.cpp +++ b/UI/win-update/updater/updater.cpp @@ -1047,6 +1047,7 @@ static bool UpdateVS2017Redists(json_t *root) DeleteFile(destPath.c_str()); Status(L"Update failed: Couldn't verify integrity of %s", L"Visual C++ 2017 Redistributable"); + return false; } /* ------------------------------------------ * @@ -1070,6 +1071,7 @@ static bool UpdateVS2017Redists(json_t *root) WaitForSingleObject(pi.hProcess, INFINITE); CloseHandle(pi.hProcess); } else { + DeleteFile(destPath.c_str()); Status(L"Update failed: Could not execute " L"%s (error code %d)", L"Visual C++ 2017 Redistributable",