From c7923bcbe424eb2d29ba20fd9c2a4f46e8889e2d Mon Sep 17 00:00:00 2001 From: jp9000 Date: Sun, 8 May 2016 11:15:20 -0700 Subject: [PATCH] obs-qsv11: Add deprecated warning for forced CBR mode Using the "cbr" parameter is now considered deprecated in favor of using "rate_control" to set the rate control method. --- plugins/obs-qsv11/obs-qsv11.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/plugins/obs-qsv11/obs-qsv11.c b/plugins/obs-qsv11/obs-qsv11.c index e3994665e..42002f2ac 100644 --- a/plugins/obs-qsv11/obs-qsv11.c +++ b/plugins/obs-qsv11/obs-qsv11.c @@ -308,9 +308,16 @@ static void update_params(struct obs_qsv *obsqsv, obs_data_t *settings) else if (astrcmpi(profile, "high") == 0) obsqsv->params.nCodecProfile = MFX_PROFILE_AVC_HIGH; - /* internal convenience parameter, overrides rate control param */ - if (cbr_override) + /* internal convenience parameter, overrides rate control param + * XXX: Deprecated */ + if (cbr_override) { + warn("\"cbr\" setting has been deprecated for all encoders! " + "Please set \"rate_control\" to \"CBR\" instead. " + "Forcing CBR mode. " + "(Note to all: this is why you shouldn't use strings for " + "common settings)"); rate_control = "CBR"; + } if (astrcmpi(rate_control, "CBR") == 0) obsqsv->params.nRateControl = MFX_RATECONTROL_CBR;