diff --git a/UI/context-bar-controls.cpp b/UI/context-bar-controls.cpp index ff6eda919..da55f4d90 100644 --- a/UI/context-bar-controls.cpp +++ b/UI/context-bar-controls.cpp @@ -573,7 +573,8 @@ void ColorSourceToolbar::on_choose_clicked() QColorDialog::ColorDialogOptions options; options |= QColorDialog::ShowAlphaChannel; -#ifndef _WIN32 +#ifdef __linux__ + // TODO: Revisit hang on Ubuntu with native dialog options |= QColorDialog::DontUseNativeDialog; #endif @@ -695,7 +696,8 @@ void TextSourceToolbar::on_selectColor_clicked() QColorDialog::ColorDialogOptions options; options |= QColorDialog::ShowAlphaChannel; -#ifndef _WIN32 +#ifdef __linux__ + // TODO: Revisit hang on Ubuntu with native dialog options |= QColorDialog::DontUseNativeDialog; #endif diff --git a/UI/properties-view.cpp b/UI/properties-view.cpp index d46f9ec80..524a2d2bb 100644 --- a/UI/properties-view.cpp +++ b/UI/properties-view.cpp @@ -1813,15 +1813,18 @@ bool WidgetInfo::ColorChangedInternal(const char *setting, bool supportAlpha) options |= QColorDialog::ShowAlphaChannel; } - /* The native dialog on OSX has all kinds of problems, like closing - * other open QDialogs on exit, and - * https://bugreports.qt-project.org/browse/QTBUG-34532 - */ -#ifndef _WIN32 +#ifdef __linux__ + // TODO: Revisit hang on Ubuntu with native dialog options |= QColorDialog::DontUseNativeDialog; #endif color = QColorDialog::getColor(color, view, QT_UTF8(desc), options); + +#ifdef __APPLE__ + // TODO: Revisit when QTBUG-42661 is fixed + widget->window()->raise(); +#endif + if (!color.isValid()) return false; diff --git a/UI/window-basic-main.cpp b/UI/window-basic-main.cpp index b0f19643d..b5569978c 100644 --- a/UI/window-basic-main.cpp +++ b/UI/window-basic-main.cpp @@ -9721,7 +9721,8 @@ void OBSBasic::ColorChange() obs_data_get_string(curPrivData, "color"); const char *customColor = *oldColor != 0 ? oldColor : "#55FF0000"; -#ifndef _WIN32 +#ifdef __linux__ + // TODO: Revisit hang on Ubuntu with native dialog options |= QColorDialog::DontUseNativeDialog; #endif diff --git a/UI/window-basic-settings-a11y.cpp b/UI/window-basic-settings-a11y.cpp index c75d19731..03e929004 100644 --- a/UI/window-basic-settings-a11y.cpp +++ b/UI/window-basic-settings-a11y.cpp @@ -36,7 +36,8 @@ QColor OBSBasicSettings::GetColor(uint32_t colorVal, QString label) { QColorDialog::ColorDialogOptions options; -#ifndef _WIN32 +#ifdef __linux__ + // TODO: Revisit hang on Ubuntu with native dialog options |= QColorDialog::DontUseNativeDialog; #endif