From e5f05473e72b4c3e434bee6d930adfebec91c182 Mon Sep 17 00:00:00 2001 From: Fred Emmott Date: Mon, 8 Feb 2021 14:46:38 -0600 Subject: [PATCH] decklink-ui: fix double free of settings This leads to a crash when the output is stopped, either by clicking the stop button or when exiting OBS studio. This crash is: - intermittent in release builds - reliable for me in debug builds It is held by an `OBSData`, which, if not null, will automatically call `obs_data_release()` on scope exit. --- UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp b/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp index 1cf71fe2a..f6fa78d69 100644 --- a/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp +++ b/UI/frontend-plugins/decklink-output-ui/decklink-ui-main.cpp @@ -68,7 +68,6 @@ void output_start() settings, NULL); bool started = obs_output_start(output); - obs_data_release(settings); main_output_running = started;