From f9b038513a1bb4a2c2cef1d2d00ce4395f0624bd Mon Sep 17 00:00:00 2001 From: Matt Gajownik Date: Mon, 24 Jan 2022 18:30:54 +1100 Subject: [PATCH] UI: Fix Settings save crash on old Windows versions WidgetChanged doesn't contain a null check, resulting in a crash when looking at the value for the new Hide OBS From Capture setting. Fixes #5854 --- UI/window-basic-settings.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UI/window-basic-settings.cpp b/UI/window-basic-settings.cpp index 10b278c33..2121c98bb 100644 --- a/UI/window-basic-settings.cpp +++ b/UI/window-basic-settings.cpp @@ -2994,7 +2994,7 @@ void OBSBasicSettings::SaveGeneralSettings() ui->enableAutoUpdates->isChecked()); #endif #ifdef _WIN32 - if (WidgetChanged(ui->hideOBSFromCapture)) { + if (ui->hideOBSFromCapture && WidgetChanged(ui->hideOBSFromCapture)) { bool hide_window = ui->hideOBSFromCapture->isChecked(); config_set_bool(GetGlobalConfig(), "BasicWindow", "HideOBSWindowsFromCapture", hide_window);