From fef92a8a434eeca3dec556039cd8edeaf5928dff Mon Sep 17 00:00:00 2001 From: Richard Stanway Date: Sat, 26 Aug 2023 01:25:07 +0200 Subject: [PATCH] libobs: Log if CreateProcessW fails on Windows This is used by the test programs as well as ffmpeg-mux. If a process fails to start it's quite bad so we would like to know why. --- libobs/util/pipe-windows.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libobs/util/pipe-windows.c b/libobs/util/pipe-windows.c index fe32dbdc2..65d52ba1e 100644 --- a/libobs/util/pipe-windows.c +++ b/libobs/util/pipe-windows.c @@ -70,6 +70,11 @@ static inline bool create_process(const char *cmd_line, HANDLE stdin_handle, if (success) { *process = pi.hProcess; CloseHandle(pi.hThread); + } else { + // Not logging the full command line is intentional + // as it may contain stream keys etc. + blog(LOG_ERROR, "CreateProcessW failed: %lu", + GetLastError()); } bfree(cmd_line_w);