From 00fbb3c6f21f8abe9e1ae37bde8da922ffafd45a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Duffeck?= Date: Fri, 6 May 2022 10:11:41 +0200 Subject: [PATCH] Do not abort search if one space fails Also make sure to log all errors. --- extensions/search/pkg/search/provider/searchprovider.go | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/extensions/search/pkg/search/provider/searchprovider.go b/extensions/search/pkg/search/provider/searchprovider.go index 8914e0273..438511cc6 100644 --- a/extensions/search/pkg/search/provider/searchprovider.go +++ b/extensions/search/pkg/search/provider/searchprovider.go @@ -103,15 +103,18 @@ func (p *Provider) Search(ctx context.Context, req *searchsvc.SearchRequest) (*s ResourceId: space.Root, }) if err != nil { - return nil, err + p.logger.Error().Err(err).Str("space", space.Id.OpaqueId).Msg("failed to get patch for grant space root") + continue } if gpRes.Status.Code != rpcv1beta1.Code_CODE_OK { - return nil, errtypes.NewErrtypeFromStatus(gpRes.Status) + p.logger.Error().Interface("status", gpRes.Status).Str("space", space.Id.OpaqueId).Msg("failed to get patch for grant space root") + continue } mountpointPrefix = utils.MakeRelativePath(gpRes.Path) sid, oid, err := storagespace.SplitID(mountpointId) if err != nil { - return nil, err + p.logger.Error().Err(err).Str("space", space.Id.OpaqueId).Str("mountpointId", mountpointId).Msg("invalid mountpoint space id") + continue } mountpointRootId = &searchmsg.ResourceID{ StorageId: sid,