fix: typos, naming clashes, error messages and deprecations

services/auth-basic/pkg/command/server.go

@@ -43,8 +43,8 @@ func Server(cfg *config.Config) *cli.Command {
 
 			defer cancel()
 
-			// the reva runtime calls os.Exit in the case of a failure and there is no way for the oCIS
-			// runtime to catch it and restart a reva service. Therefore we need to ensure the service has
+			// the reva runtime calls `os.Exit` in the case of a failure and there is no way for the oCIS
+			// runtime to catch it and restart a reva service. Therefore, we need to ensure the service has
 			// everything it needs, before starting the service.
 			// In this case: CA certificates
 			if cfg.AuthProvider == "ldap" {

services/auth-basic/pkg/logging/logging.go

@@ -5,7 +5,7 @@ import (
 	"github.com/owncloud/ocis/v2/services/auth-basic/pkg/config"
 )
 
-// LoggerFromConfig initializes a service-specific logger instance.
+// Configure initializes a service-specific logger instance.
 func Configure(name string, cfg *config.Log) log.Logger {
 	return log.NewLogger(
 		log.Name(name),

services/auth-basic/pkg/server/debug/server.go

@@ -39,7 +39,7 @@ func health(cfg *config.Config) func(http.ResponseWriter, *http.Request) {
 		// TODO: check if services are up and running
 
 		_, err := io.WriteString(w, http.StatusText(http.StatusOK))
-		// io.WriteString should not fail but if it does we want to know.
+		// io.WriteString should not fail but if it does, we want to know.
 		if err != nil {
 			panic(err)
 		}
@@ -55,7 +55,7 @@ func ready(cfg *config.Config) func(http.ResponseWriter, *http.Request) {
 		// TODO: check if services are up and running
 
 		_, err := io.WriteString(w, http.StatusText(http.StatusOK))
-		// io.WriteString should not fail but if it does we want to know.
+		// io.WriteString should not fail but if it does, we want to know.
 		if err != nil {
 			panic(err)
 		}