From 1242e483b3a9a592cf920f84a4f02d3fa2f8b04b Mon Sep 17 00:00:00 2001
From: Christian Richter <crichter@owncloud.com>
Date: Wed, 4 Sep 2024 16:51:48 +0200
Subject: [PATCH] improve error handling

Signed-off-by: Christian Richter <crichter@owncloud.com>
---
 services/graph/pkg/service/v0/base.go | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/services/graph/pkg/service/v0/base.go b/services/graph/pkg/service/v0/base.go
index 96cba9b072..26f77c3061 100644
--- a/services/graph/pkg/service/v0/base.go
+++ b/services/graph/pkg/service/v0/base.go
@@ -638,6 +638,10 @@ func (g BaseGraphService) getCS3PublicShareByID(ctx context.Context, permissionI
 			},
 		},
 	)
+	if err != nil {
+		return nil, err
+	}
+
 	if err := errorcode.FromCS3Status(getPublicShareResp.GetStatus(), err); err != nil {
 		return nil, err
 	}
@@ -661,6 +665,10 @@ func (g BaseGraphService) removePublicShare(ctx context.Context, permissionID st
 				},
 			},
 		})
+	if err != nil {
+		return err
+	}
+
 	if err := errorcode.FromCS3Status(removePublicShareResp.GetStatus(), err); err != nil {
 		return err
 	}
@@ -685,6 +693,9 @@ func (g BaseGraphService) removeUserShare(ctx context.Context, permissionID stri
 				},
 			},
 		})
+	if err != nil {
+		return err
+	}
 
 	if err := errorcode.FromCS3Status(removeShareResp.GetStatus(), err); err != nil {
 		return err
@@ -714,6 +725,9 @@ func (g BaseGraphService) removeSpacePermission(ctx context.Context, permissionI
 			},
 		},
 	})
+	if err != nil {
+		return err
+	}
 
 	if err := errorcode.FromCS3Status(removeShareResp.GetStatus(), err); err != nil {
 		return err
@@ -747,6 +761,10 @@ func (g BaseGraphService) getCS3UserShareByID(ctx context.Context, permissionID
 				},
 			},
 		})
+	if err != nil {
+		return nil, err
+	}
+
 	if err := errorcode.FromCS3Status(getShareResp.GetStatus(), err); err != nil {
 		return nil, err
 	}
@@ -897,6 +915,9 @@ func (g BaseGraphService) updateUserShare(ctx context.Context, permissionID stri
 	}
 
 	updateUserShareResp, err := gatewayClient.UpdateShare(ctx, &cs3UpdateShareReq)
+	if err != nil {
+		return nil, err
+	}
 	if err := errorcode.FromCS3Status(updateUserShareResp.GetStatus(), err); err != nil {
 		return nil, err
 	}