From c1ac8777db857fcf781501490356e630c503692f Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Mon, 20 Jan 2020 15:56:14 +0100 Subject: [PATCH 1/5] changelog for 1.3.0 --- CHANGELOG.md | 21 +++++++++++++++++-- .../fix-serving-static-issues.md | 6 ++++++ .../issue-8.md | 0 .../tls-support-for-http-services.md | 5 +++++ changelog/README.md | 2 ++ 5 files changed, 32 insertions(+), 2 deletions(-) create mode 100644 changelog/1.3.0_2020-01-20/fix-serving-static-issues.md rename changelog/{unreleased => 1.3.0_2020-01-20}/issue-8.md (100%) create mode 100644 changelog/1.3.0_2020-01-20/tls-support-for-http-services.md diff --git a/CHANGELOG.md b/CHANGELOG.md index 678267e9d..2d86ceb34 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,13 +1,30 @@ -# Changelog for unreleased +# Changelog for 1.3.0 -The following sections list the changes for unreleased. +The following sections list the changes for 1.3.0. ## Summary + * Fix #14: Fix serving static assets + * Chg #19: Add TLS support for http services * Enh #8: Introduce OpenID Connect middleware ## Details + * Bugfix #14: Fix serving static assets + + Ocis-hello used "/" as root. adding another / caused the static middleware to always fail + stripping that prefix. All requests will return 404. setting root to "" in the `ocis-hello` + flag does not work because chi reports that routes need to start with a /. + `path.Clean(root+"/")` would yield "" for root="/" + + https://github.com/owncloud/ocis-pkg/pull/14 + + * Change #19: Add TLS support for http services + + `ocis-pkg` http services support TLS. + + https://github.com/owncloud/ocis-pkg/issues/19 + * Enhancement #8: Introduce OpenID Connect middleware Added an openid connect middleware that will try to authenticate users using OpenID Connect. diff --git a/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md b/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md new file mode 100644 index 000000000..2ad9fea9d --- /dev/null +++ b/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md @@ -0,0 +1,6 @@ +Bugfix: Fix serving static assets + +ocis-hello used "/" as root. adding another / caused the static middleware to always fail stripping that prefix. All requests will return 404. +setting root to "" in the `ocis-hello` flag does not work because chi reports that routes need to start with a /. `path.Clean(root+"/")` would yield "" for root="/" + +https://github.com/owncloud/ocis-pkg/pull/14 \ No newline at end of file diff --git a/changelog/unreleased/issue-8.md b/changelog/1.3.0_2020-01-20/issue-8.md similarity index 100% rename from changelog/unreleased/issue-8.md rename to changelog/1.3.0_2020-01-20/issue-8.md diff --git a/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md new file mode 100644 index 000000000..563ac1189 --- /dev/null +++ b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md @@ -0,0 +1,5 @@ +Change: Add TLS support for http services + +`ocis-pkg` http services support TLS. + +https://github.com/owncloud/ocis-pkg/issues/19 \ No newline at end of file diff --git a/changelog/README.md b/changelog/README.md index 0ae5d5b3e..a6bf989ae 100644 --- a/changelog/README.md +++ b/changelog/README.md @@ -4,3 +4,5 @@ We are using [calens](https://github.com/restic/calens) to properly generate a changelog before we are tagging a new release. To get an idea how this could look like would be the best reference. + +We're using kebab case for naming the changelog files: `kebab-case-looks-like-this` From a2a12063efd679b4bed814e6842e9ca3019804ea Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Mon, 20 Jan 2020 16:04:11 +0100 Subject: [PATCH 2/5] update description --- changelog/1.3.0_2020-01-20/tls-support-for-http-services.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md index 563ac1189..26041c210 100644 --- a/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md +++ b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md @@ -1,5 +1,5 @@ Change: Add TLS support for http services -`ocis-pkg` http services support TLS. +`ocis-pkg` http services support TLS. The idea behind is setting the issuer on phoenix's `config.json` to `https`. Or in other words, use https to access the Kopano extension, and authenticate using an SSL certificate. https://github.com/owncloud/ocis-pkg/issues/19 \ No newline at end of file From 91e2402e1c904350b3d5d5b3e000ea97e94f2cca Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Mon, 20 Jan 2020 16:05:13 +0100 Subject: [PATCH 3/5] generate changelog --- CHANGELOG.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 2d86ceb34..376bfd1c4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,7 +21,9 @@ The following sections list the changes for 1.3.0. * Change #19: Add TLS support for http services - `ocis-pkg` http services support TLS. + `ocis-pkg` http services support TLS. The idea behind is setting the issuer on phoenix's + `config.json` to `https`. Or in other words, use https to access the Kopano extension, and + authenticate using an SSL certificate. https://github.com/owncloud/ocis-pkg/issues/19 From e8b4d4a366cbd7927143eaa632300d11d343937a Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Mon, 20 Jan 2020 16:34:59 +0100 Subject: [PATCH 4/5] re-enable editorconfig --- changelog/1.3.0_2020-01-20/fix-serving-static-issues.md | 2 +- changelog/1.3.0_2020-01-20/issue-8.md | 2 +- changelog/1.3.0_2020-01-20/tls-support-for-http-services.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md b/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md index 2ad9fea9d..e90ca0a25 100644 --- a/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md +++ b/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md @@ -3,4 +3,4 @@ Bugfix: Fix serving static assets ocis-hello used "/" as root. adding another / caused the static middleware to always fail stripping that prefix. All requests will return 404. setting root to "" in the `ocis-hello` flag does not work because chi reports that routes need to start with a /. `path.Clean(root+"/")` would yield "" for root="/" -https://github.com/owncloud/ocis-pkg/pull/14 \ No newline at end of file +https://github.com/owncloud/ocis-pkg/pull/14 diff --git a/changelog/1.3.0_2020-01-20/issue-8.md b/changelog/1.3.0_2020-01-20/issue-8.md index 69d64fde8..7b7c43c55 100644 --- a/changelog/1.3.0_2020-01-20/issue-8.md +++ b/changelog/1.3.0_2020-01-20/issue-8.md @@ -3,4 +3,4 @@ Enhancement: Introduce OpenID Connect middleware Added an openid connect middleware that will try to authenticate users using OpenID Connect. The claims will be added to the context of the request. -https://github.com/owncloud/ocis-pkg/issues/8 \ No newline at end of file +https://github.com/owncloud/ocis-pkg/issues/8 diff --git a/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md index 26041c210..b6d744186 100644 --- a/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md +++ b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md @@ -2,4 +2,4 @@ Change: Add TLS support for http services `ocis-pkg` http services support TLS. The idea behind is setting the issuer on phoenix's `config.json` to `https`. Or in other words, use https to access the Kopano extension, and authenticate using an SSL certificate. -https://github.com/owncloud/ocis-pkg/issues/19 \ No newline at end of file +https://github.com/owncloud/ocis-pkg/issues/19 From 7f9c8e4cf60603ca68582bf43f5623617f391f86 Mon Sep 17 00:00:00 2001 From: "A.Unger" Date: Mon, 20 Jan 2020 16:39:45 +0100 Subject: [PATCH 5/5] changelog files with 80 lines width --- changelog/1.3.0_2020-01-20/fix-serving-static-issues.md | 6 ++++-- changelog/1.3.0_2020-01-20/issue-8.md | 4 ++-- changelog/1.3.0_2020-01-20/tls-support-for-http-services.md | 4 +++- changelog/README.md | 4 +++- 4 files changed, 12 insertions(+), 6 deletions(-) diff --git a/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md b/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md index e90ca0a25..010430b6a 100644 --- a/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md +++ b/changelog/1.3.0_2020-01-20/fix-serving-static-issues.md @@ -1,6 +1,8 @@ Bugfix: Fix serving static assets -ocis-hello used "/" as root. adding another / caused the static middleware to always fail stripping that prefix. All requests will return 404. -setting root to "" in the `ocis-hello` flag does not work because chi reports that routes need to start with a /. `path.Clean(root+"/")` would yield "" for root="/" +ocis-hello used "/" as root. adding another / caused the static middleware to +always fail stripping that prefix. All requests will return 404. Setting root +to `""` in the `ocis-hello` flag does not work because Chi reports that routes +need to start with `/`. `path.Clean(root+"/")` would yield `""` for `root="/"`. https://github.com/owncloud/ocis-pkg/pull/14 diff --git a/changelog/1.3.0_2020-01-20/issue-8.md b/changelog/1.3.0_2020-01-20/issue-8.md index 7b7c43c55..8e064234b 100644 --- a/changelog/1.3.0_2020-01-20/issue-8.md +++ b/changelog/1.3.0_2020-01-20/issue-8.md @@ -1,6 +1,6 @@ Enhancement: Introduce OpenID Connect middleware -Added an openid connect middleware that will try to authenticate users using OpenID Connect. -The claims will be added to the context of the request. +Added an openid connect middleware that will try to authenticate users using +OpenID Connect. The claims will be added to the context of the request. https://github.com/owncloud/ocis-pkg/issues/8 diff --git a/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md index b6d744186..b1f8660d8 100644 --- a/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md +++ b/changelog/1.3.0_2020-01-20/tls-support-for-http-services.md @@ -1,5 +1,7 @@ Change: Add TLS support for http services -`ocis-pkg` http services support TLS. The idea behind is setting the issuer on phoenix's `config.json` to `https`. Or in other words, use https to access the Kopano extension, and authenticate using an SSL certificate. +`ocis-pkg` http services support TLS. The idea behind is setting the issuer on +phoenix's `config.json` to `https`. Or in other words, use https to access the +Kopano extension, and authenticate using an SSL certificate. https://github.com/owncloud/ocis-pkg/issues/19 diff --git a/changelog/README.md b/changelog/README.md index a6bf989ae..f83a983fd 100644 --- a/changelog/README.md +++ b/changelog/README.md @@ -5,4 +5,6 @@ changelog before we are tagging a new release. To get an idea how this could look like would be the best reference. -We're using kebab case for naming the changelog files: `kebab-case-looks-like-this` +We're using kebab case for naming the changelog files: + +`kebab-case-looks-like-this`