From 3a8b370a08403d95be0780dbf858eeceaf704003 Mon Sep 17 00:00:00 2001 From: Ralf Haferkamp Date: Thu, 14 Aug 2025 15:36:23 +0200 Subject: [PATCH] fix(proxy): First login fails in auto provision setups Redeclaring the `err` variable inside the if statement made the later error check fail even when the user was successfully created. Fixes: #1277 --- services/proxy/pkg/middleware/account_resolver.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/proxy/pkg/middleware/account_resolver.go b/services/proxy/pkg/middleware/account_resolver.go index c2c69d76aa..5b3a3be957 100644 --- a/services/proxy/pkg/middleware/account_resolver.go +++ b/services/proxy/pkg/middleware/account_resolver.go @@ -11,6 +11,7 @@ import ( "github.com/opencloud-eu/opencloud/services/proxy/pkg/user/backend" "github.com/opencloud-eu/opencloud/services/proxy/pkg/userroles" + cs3user "github.com/cs3org/go-cs3apis/cs3/identity/user/v1beta1" "github.com/opencloud-eu/opencloud/pkg/log" "github.com/opencloud-eu/opencloud/pkg/oidc" revactx "github.com/opencloud-eu/reva/v2/pkg/ctx" @@ -125,7 +126,8 @@ func (m accountResolver) ServeHTTP(w http.ResponseWriter, req *http.Request) { return } m.logger.Debug().Interface("claims", claims).Msg("Autoprovisioning user") - newuser, err := m.userProvider.CreateUserFromClaims(req.Context(), claims) + var newuser *cs3user.User + newuser, err = m.userProvider.CreateUserFromClaims(req.Context(), claims) if err != nil { m.logger.Error().Err(err).Msg("Autoprovisioning user failed") w.WriteHeader(http.StatusInternalServerError)