From 47bd5735e48a7755dbdb6aa0a5b9b4bc28183236 Mon Sep 17 00:00:00 2001 From: kobergj Date: Fri, 29 Nov 2024 15:37:39 +0100 Subject: [PATCH] fix(docs): better service startup explanation Co-authored-by: Martin --- docs/services/general-info/new-service-checklist.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/docs/services/general-info/new-service-checklist.md b/docs/services/general-info/new-service-checklist.md index 33a176ee11..eb72f9ad47 100644 --- a/docs/services/general-info/new-service-checklist.md +++ b/docs/services/general-info/new-service-checklist.md @@ -28,8 +28,11 @@ Use this checklist with copy/paste in your PR - right from the beginning. It ren - [ ] If new global envvars are introduced, the name must start with `OCIS_`. - [ ] Add the service to the makefile in the ocis repo root. - [ ] Service startup: - - For automatic startup: `ocis/pkg/runtime` (service/service.go) - - Exclude from automatic startup, add it to the `populate optional services` block + - add it to `ocis/pkg/command/services.go` + - Include for automatic startup: + - add it to `ocis/pkg/runtime/service/service.go` + - Exclude from automatic startup: + - add it to the `populate optional services` block in `ocis/pkg/runtime/service/service.go` - Add the service config to `ocis-pkg/config/defaultconfig.go` - [ ] If the service is using service accounts, add it to `ocis/pkg/init/init.go` - [ ] Check that the service properly responds to `ocis health` and has `/healthz` and `/readyz` endpoints