From 3e6fb93f20bad61ddfc281f40a876cf223f098ea Mon Sep 17 00:00:00 2001 From: swoichha Date: Wed, 16 Dec 2020 10:24:00 +0545 Subject: [PATCH 1/4] run tus test for file with invalid-name --- .drone.star | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.drone.star b/.drone.star index e0232a5074..0c4328cdcc 100644 --- a/.drone.star +++ b/.drone.star @@ -16,8 +16,8 @@ config = { 'onlyoffice':'frontend' }, 'apiTests': { - 'coreBranch': 'master', - 'coreCommit': '27eaa32d777052d1d210647cd38895e647c48fed', + 'coreBranch': 'tus-invalid-file-names', + 'coreCommit': ' ', 'numberOfParts': 10 }, 'uiTests': { From 9c1ac176cab2a69319b557c97ff63efb8a2b78a0 Mon Sep 17 00:00:00 2001 From: swoichha Date: Thu, 17 Dec 2020 13:29:53 +0545 Subject: [PATCH 2/4] added list of scenarios into expected failure file --- .drone.star | 2 +- .../expected-failures-on-OCIS-storage.txt | 10 ++++++++++ .../expected-failures-on-OWNCLOUD-storage.txt | 20 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) diff --git a/.drone.star b/.drone.star index 0c4328cdcc..cd2c3a4478 100644 --- a/.drone.star +++ b/.drone.star @@ -16,7 +16,7 @@ config = { 'onlyoffice':'frontend' }, 'apiTests': { - 'coreBranch': 'tus-invalid-file-names', + 'coreBranch': 'changes-tusTests-invalid-file-names', 'coreCommit': ' ', 'numberOfParts': 10 }, diff --git a/tests/acceptance/expected-failures-on-OCIS-storage.txt b/tests/acceptance/expected-failures-on-OCIS-storage.txt index 00d3b44572..312e6e79b2 100644 --- a/tests/acceptance/expected-failures-on-OCIS-storage.txt +++ b/tests/acceptance/expected-failures-on-OCIS-storage.txt @@ -2506,3 +2506,13 @@ apiWebdavUploadTUS/uploadToShare.feature:53 # https://github.com/owncloud/ocis/issues/1012 TUS OPTIONS requests does not reply with TUS headers when invalid password apiWebdavUploadTUS/optionsRequest.feature:29 apiWebdavUploadTUS/optionsRequest.feature:40 + +# https://github.com/owncloud/ocis/issues/1001 invalid file-names should not be created using the TUS protocol +apiWebdavUploadTUS/uploadFile.feature:135 +apiWebdavUploadTUS/uploadFile.feature:136 +apiWebdavUploadTUS/uploadFile.feature:137 +apiWebdavUploadTUS/uploadFile.feature:138 +apiWebdavUploadTUS/uploadFile.feature:139 +apiWebdavUploadTUS/uploadFile.feature:140 +apiWebdavUploadTUS/uploadFile.feature:141 +apiWebdavUploadTUS/uploadFile.feature:142 diff --git a/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt b/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt index 2bd0d81abd..bde89f39ad 100644 --- a/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt +++ b/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt @@ -2427,3 +2427,23 @@ apiWebdavUploadTUS/uploadToNonExistingFolder.feature:43 apiWebdavUploadTUS/uploadToNonExistingFolder.feature:44 apiWebdavUploadTUS/uploadToNonExistingFolder.feature:57 apiWebdavUploadTUS/uploadToNonExistingFolder.feature:58 + +# https://github.com/owncloud/ocis/issues/1039 The Patch Request Response doesnot contain a body +apiWebdavUploadTUS/uploadToNonExistingFolder.feature:29 +apiWebdavUploadTUS/uploadToNonExistingFolder.feature:30 + +# https://github.com/owncloud/ocis/issues/1047 500 Internal Server Error on Post request for TUS upload to a non-existing folder on the received share +apiWebdavUploadTUS/uploadToNonExistingFolder.feature:43 +apiWebdavUploadTUS/uploadToNonExistingFolder.feature:44 +apiWebdavUploadTUS/uploadToNonExistingFolder.feature:57 +apiWebdavUploadTUS/uploadToNonExistingFolder.feature:58 + +# https://github.com/owncloud/ocis/issues/1001 invalid file-names should not be created using the TUS protocol +apiWebdavUploadTUS/uploadFile.feature:135 +apiWebdavUploadTUS/uploadFile.feature:136 +apiWebdavUploadTUS/uploadFile.feature:137 +apiWebdavUploadTUS/uploadFile.feature:138 +apiWebdavUploadTUS/uploadFile.feature:139 +apiWebdavUploadTUS/uploadFile.feature:140 +apiWebdavUploadTUS/uploadFile.feature:141 +apiWebdavUploadTUS/uploadFile.feature:142 From ec6359d7ad918a4ea32ff63db3eec8e8439cf657 Mon Sep 17 00:00:00 2001 From: Artur Neumann Date: Thu, 17 Dec 2020 15:58:47 +0545 Subject: [PATCH 3/4] expected failures of new trashbin tests --- .../expected-failures-on-OCIS-storage.txt | 61 +++++++++++++++---- .../expected-failures-on-OWNCLOUD-storage.txt | 57 +++++++++++++---- 2 files changed, 93 insertions(+), 25 deletions(-) diff --git a/tests/acceptance/expected-failures-on-OCIS-storage.txt b/tests/acceptance/expected-failures-on-OCIS-storage.txt index 312e6e79b2..8aa865f6e8 100644 --- a/tests/acceptance/expected-failures-on-OCIS-storage.txt +++ b/tests/acceptance/expected-failures-on-OCIS-storage.txt @@ -936,16 +936,24 @@ apiShareReshareToShares3/reShareWithExpiryDate.feature:337 apiShareReshareToShares3/reShareWithExpiryDate.feature:338 # # https://github.com/owncloud/product/issues/254 empty trashbin does not work -# https://github.com/owncloud/ocis/issues/551 delete from trashbin does not work # apiTrashbin/trashbinDelete.feature:31 apiTrashbin/trashbinDelete.feature:32 apiTrashbin/trashbinDelete.feature:33 apiTrashbin/trashbinDelete.feature:34 apiTrashbin/trashbinDelete.feature:37 +# +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# apiTrashbin/trashbinDelete.feature:50 apiTrashbin/trashbinDelete.feature:67 # +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1077 [QA] trashcan cannot delete a deep tree +# +apiTrashbin/trashbinDelete.feature:107 +apiTrashbin/trashbinDelete.feature:123 +# # https://github.com/owncloud/product/issues/255 trashbin filename invalid for nested files/folders # apiTrashbin/trashbinFilesFolders.feature:44 @@ -976,29 +984,21 @@ apiTrashbin/trashbinFilesFolders.feature:245 apiTrashbin/trashbinFilesFolders.feature:246 apiTrashbin/trashbinFilesFolders.feature:247 # -# https://github.com/owncloud/core/issues/38006 Review and fix the tests that have sharing step to work with ocis +# https://github.com/owncloud/ocis/issues/1116 PROPFIND on trashbin with Depth: infinity only shows the first level # -apiTrashbin/trashbinRestore.feature:40 -apiTrashbin/trashbinRestore.feature:41 +apiTrashbin/trashbinFilesFolders.feature:272 +apiTrashbin/trashbinFilesFolders.feature:273 # -# https://github.com/owncloud/ocis-reva/issues/117 cannot restore trashbin item +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong # apiTrashbin/trashbinRestore.feature:54 apiTrashbin/trashbinRestore.feature:55 apiTrashbin/trashbinRestore.feature:70 apiTrashbin/trashbinRestore.feature:71 -apiTrashbin/trashbinRestore.feature:90 -apiTrashbin/trashbinRestore.feature:91 -apiTrashbin/trashbinRestore.feature:92 -apiTrashbin/trashbinRestore.feature:93 -apiTrashbin/trashbinRestore.feature:94 -apiTrashbin/trashbinRestore.feature:95 apiTrashbin/trashbinRestore.feature:118 apiTrashbin/trashbinRestore.feature:119 apiTrashbin/trashbinRestore.feature:120 apiTrashbin/trashbinRestore.feature:121 -apiTrashbin/trashbinRestore.feature:138 -apiTrashbin/trashbinRestore.feature:139 apiTrashbin/trashbinRestore.feature:211 apiTrashbin/trashbinRestore.feature:212 apiTrashbin/trashbinRestore.feature:255 @@ -1009,8 +1009,43 @@ apiTrashbin/trashbinRestore.feature:259 apiTrashbin/trashbinRestore.feature:260 apiTrashbin/trashbinRestore.feature:275 apiTrashbin/trashbinRestore.feature:276 +apiTrashbin/trashbinRestore.feature:292 +apiTrashbin/trashbinRestore.feature:293 +# +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1121 trash-bin restore move does not send back Etag and other headers +# +apiTrashbin/trashbinRestore.feature:40 +apiTrashbin/trashbinRestore.feature:41 +apiTrashbin/trashbinRestore.feature:138 +apiTrashbin/trashbinRestore.feature:139 +# +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1122 cannot restore to a different file-name +# https://github.com/owncloud/ocis/issues/1121 trash-bin restore move does not send back Etag and other headers +# +apiTrashbin/trashbinRestore.feature:90 +apiTrashbin/trashbinRestore.feature:91 +apiTrashbin/trashbinRestore.feature:92 +apiTrashbin/trashbinRestore.feature:93 +apiTrashbin/trashbinRestore.feature:94 +apiTrashbin/trashbinRestore.feature:95 +# +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1122 cannot restore to a different file-name +# +apiTrashbin/trashbinRestore.feature:311 +apiTrashbin/trashbinRestore.feature:312 +apiTrashbin/trashbinRestore.feature:330 +apiTrashbin/trashbinRestore.feature:331 +# +# https://github.com/owncloud/ocis/issues/1123 deleting a received share-folder moves it to trash-bin but does not unshare it +# apiTrashbin/trashbinSharingToShares.feature:24 apiTrashbin/trashbinSharingToShares.feature:25 +# +# https://github.com/owncloud/ocis/issues/1124 deleting a file inside a received shared folder is moved to the trash-bin of the sharer not the receiver +# apiTrashbin/trashbinSharingToShares.feature:40 apiTrashbin/trashbinSharingToShares.feature:41 apiTrashbin/trashbinSharingToShares.feature:63 diff --git a/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt b/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt index bde89f39ad..56b7db36a9 100644 --- a/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt +++ b/tests/acceptance/expected-failures-on-OWNCLOUD-storage.txt @@ -907,6 +907,12 @@ apiTrashbin/trashbinDelete.feature:37 apiTrashbin/trashbinDelete.feature:50 apiTrashbin/trashbinDelete.feature:67 # +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1077 [QA] trashcan cannot delete a deep tree +# +apiTrashbin/trashbinDelete.feature:107 +apiTrashbin/trashbinDelete.feature:123 +# # https://github.com/owncloud/product/issues/255 trashbin filename invalid for nested files/folders # apiTrashbin/trashbinFilesFolders.feature:44 @@ -946,29 +952,21 @@ apiTrashbin/trashbinFilesFolders.feature:245 apiTrashbin/trashbinFilesFolders.feature:246 apiTrashbin/trashbinFilesFolders.feature:247 # -# https://github.com/owncloud/core/issues/38006 Review and fix the tests that have sharing step to work with ocis +# https://github.com/owncloud/ocis/issues/1116 PROPFIND on trashbin with Depth: infinity only shows the first level # -apiTrashbin/trashbinRestore.feature:40 -apiTrashbin/trashbinRestore.feature:41 +apiTrashbin/trashbinFilesFolders.feature:272 +apiTrashbin/trashbinFilesFolders.feature:273 # -# https://github.com/owncloud/ocis-reva/issues/117 cannot restore trashbin item +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong # apiTrashbin/trashbinRestore.feature:54 apiTrashbin/trashbinRestore.feature:55 apiTrashbin/trashbinRestore.feature:70 apiTrashbin/trashbinRestore.feature:71 -apiTrashbin/trashbinRestore.feature:90 -apiTrashbin/trashbinRestore.feature:91 -apiTrashbin/trashbinRestore.feature:92 -apiTrashbin/trashbinRestore.feature:93 -apiTrashbin/trashbinRestore.feature:94 -apiTrashbin/trashbinRestore.feature:95 apiTrashbin/trashbinRestore.feature:118 apiTrashbin/trashbinRestore.feature:119 apiTrashbin/trashbinRestore.feature:120 apiTrashbin/trashbinRestore.feature:121 -apiTrashbin/trashbinRestore.feature:138 -apiTrashbin/trashbinRestore.feature:139 apiTrashbin/trashbinRestore.feature:211 apiTrashbin/trashbinRestore.feature:212 apiTrashbin/trashbinRestore.feature:255 @@ -979,8 +977,43 @@ apiTrashbin/trashbinRestore.feature:259 apiTrashbin/trashbinRestore.feature:260 apiTrashbin/trashbinRestore.feature:275 apiTrashbin/trashbinRestore.feature:276 +apiTrashbin/trashbinRestore.feature:292 +apiTrashbin/trashbinRestore.feature:293 +# +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1121 trash-bin restore move does not send back Etag and other headers +# +apiTrashbin/trashbinRestore.feature:40 +apiTrashbin/trashbinRestore.feature:41 +apiTrashbin/trashbinRestore.feature:138 +apiTrashbin/trashbinRestore.feature:139 +# +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1122 cannot restore to a different file-name +# https://github.com/owncloud/ocis/issues/1121 trash-bin restore move does not send back Etag and other headers +# +apiTrashbin/trashbinRestore.feature:90 +apiTrashbin/trashbinRestore.feature:91 +apiTrashbin/trashbinRestore.feature:92 +apiTrashbin/trashbinRestore.feature:93 +apiTrashbin/trashbinRestore.feature:94 +apiTrashbin/trashbinRestore.feature:95 +# +# https://github.com/owncloud/ocis/issues/1120 href in trashbin PROPFIND response is wrong +# https://github.com/owncloud/ocis/issues/1122 cannot restore to a different file-name +# +apiTrashbin/trashbinRestore.feature:311 +apiTrashbin/trashbinRestore.feature:312 +apiTrashbin/trashbinRestore.feature:330 +apiTrashbin/trashbinRestore.feature:331 +# +# https://github.com/owncloud/ocis/issues/1123 deleting a received share-folder moves it to trash-bin but does not unshare it +# apiTrashbin/trashbinSharingToShares.feature:24 apiTrashbin/trashbinSharingToShares.feature:25 +# +# https://github.com/owncloud/ocis/issues/1124 deleting a file inside a received shared folder is moved to the trash-bin of the sharer not the receiver +# apiTrashbin/trashbinSharingToShares.feature:40 apiTrashbin/trashbinSharingToShares.feature:41 apiTrashbin/trashbinSharingToShares.feature:63 From 80a1ca487a0f721a815563d42b47704a9a180ca6 Mon Sep 17 00:00:00 2001 From: swoichha Date: Thu, 17 Dec 2020 16:50:41 +0545 Subject: [PATCH 4/4] bump core commit id --- .drone.star | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.drone.star b/.drone.star index cd2c3a4478..7c670ae892 100644 --- a/.drone.star +++ b/.drone.star @@ -16,8 +16,8 @@ config = { 'onlyoffice':'frontend' }, 'apiTests': { - 'coreBranch': 'changes-tusTests-invalid-file-names', - 'coreCommit': ' ', + 'coreBranch': 'master', + 'coreCommit': 'c84aa4e95ac98f06dc2c17c570e65c36bfc17a78', 'numberOfParts': 10 }, 'uiTests': {