From 8312803c16043b3676246c54672af01cdb6aea2d Mon Sep 17 00:00:00 2001 From: Willy Kloucek Date: Tue, 19 Jul 2022 13:57:53 +0200 Subject: [PATCH] improve error log for "could not get user by claim" error --- changelog/unreleased/enhancement-error-by-claim.md | 7 +++++++ services/proxy/pkg/user/backend/cs3.go | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) create mode 100644 changelog/unreleased/enhancement-error-by-claim.md diff --git a/changelog/unreleased/enhancement-error-by-claim.md b/changelog/unreleased/enhancement-error-by-claim.md new file mode 100644 index 0000000000..815da1e0ea --- /dev/null +++ b/changelog/unreleased/enhancement-error-by-claim.md @@ -0,0 +1,7 @@ +Enhancement: Improve error log for "could not get user by claim" error + +We've improved the error log for "could not get user by claim" error where +previously only the "nil" error has been logged. Now we're logging the +message from the transport. + +https://github.com/owncloud/ocis/pull/4227 diff --git a/services/proxy/pkg/user/backend/cs3.go b/services/proxy/pkg/user/backend/cs3.go index cad1139a2d..d6efa2e7db 100644 --- a/services/proxy/pkg/user/backend/cs3.go +++ b/services/proxy/pkg/user/backend/cs3.go @@ -65,7 +65,7 @@ func (c *cs3backend) GetUserByClaims(ctx context.Context, claim, value string, w if res.Status.Code == rpcv1beta1.Code_CODE_NOT_FOUND { return nil, "", ErrAccountNotFound } - return nil, "", fmt.Errorf("could not get user by claim %v with value %v : %w ", claim, value, err) + return nil, "", fmt.Errorf("could not get user by claim %v with value %v : %s ", claim, value, res.Status.Message) } user := res.User