From 8b024b8f1c110f3fde383a7aeec3eb5c3f97a8f0 Mon Sep 17 00:00:00 2001 From: Sawjan Gurung Date: Wed, 23 Sep 2026 20:29:57 +0545 Subject: [PATCH] [decomposed] test(api): remove passing notification tests from expected failure (#3555) * test: remove passing notification tests from expected failure Signed-off-by: Saw-jan * fix cleanupEmptyTrashBin.feature:5 test for decomposed --------- Signed-off-by: Saw-jan Co-authored-by: v.scharf --- opencloud/pkg/command/trash.go | 2 +- tests/acceptance/expected-failures-decomposed-storage.md | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/opencloud/pkg/command/trash.go b/opencloud/pkg/command/trash.go index 9b572c3cff..7e5d2f7752 100644 --- a/opencloud/pkg/command/trash.go +++ b/opencloud/pkg/command/trash.go @@ -16,7 +16,7 @@ func TrashCommand(cfg *config.Config) *cobra.Command { trashCmd := &cobra.Command{ Use: "trash", Short: "OpenCloud trash functionality", - PreRunE: func(cmd *cobra.Command, args []string) error { + PersistentPreRunE: func(cmd *cobra.Command, args []string) error { return configlog.ReturnError(parser.ParseConfig(cfg, true)) }, RunE: func(cmd *cobra.Command, args []string) error { diff --git a/tests/acceptance/expected-failures-decomposed-storage.md b/tests/acceptance/expected-failures-decomposed-storage.md index 09e35ea1fb..955535d2da 100644 --- a/tests/acceptance/expected-failures-decomposed-storage.md +++ b/tests/acceptance/expected-failures-decomposed-storage.md @@ -325,12 +325,6 @@ _ocdav: api compatibility, return correct status code_ - [coreApiWebdavPreviews/previews.feature:264](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavPreviews/previews.feature#L264) - [coreApiWebdavPreviews/previews.feature:265](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/coreApiWebdavPreviews/previews.feature#L265) - -### notification issue #323 -- [apiNotification/emailNotification.feature:280](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/apiNotification/emailNotification.feature#L280) -- [apiNotification/emailNotification.feature:298](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/apiNotification/emailNotification.feature#L298) -- [apiNotification/spaceNotification.feature:463](https://github.com/opencloud-eu/opencloud/blob/main/tests/acceptance/features/apiNotification/spaceNotification.feature#L463) - ### Won't fix Not everything needs to be implemented for opencloud.