From 92fbdda1ec8a5df2bb91b512cf9eb7c635e11f8a Mon Sep 17 00:00:00 2001 From: Pascal Bleser Date: Wed, 3 Jun 2026 18:47:08 +0200 Subject: [PATCH] groupware: fix unit tests --- pkg/jmap/api_email.go | 2 +- pkg/structs/structs_test.go | 6 +++--- services/groupware/pkg/groupware/suppliers_test.go | 10 +++++----- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/pkg/jmap/api_email.go b/pkg/jmap/api_email.go index 085bd9ada8..2c588960bf 100644 --- a/pkg/jmap/api_email.go +++ b/pkg/jmap/api_email.go @@ -176,7 +176,7 @@ func (j *Client) GetAllEmailsInMailbox(accountId AccountId, mailboxId string, // } return command(j, ctx, cmd, func(body *Response) (*EmailSearchResults, State, Error) { - var queryResponse *EmailQueryResponse + var queryResponse EmailQueryResponse err = retrieveQuery(ctx, body, query, "0", &queryResponse) if err != nil { return nil, "", err diff --git a/pkg/structs/structs_test.go b/pkg/structs/structs_test.go index 817a7b7a2b..23a7985c9f 100644 --- a/pkg/structs/structs_test.go +++ b/pkg/structs/structs_test.go @@ -132,11 +132,11 @@ func TestMapMap(t *testing.T) { n := MapMap(m, func(a string, b int) (string, int) { return strings.ToUpper(a), b + 100 }) assert.Len(t, n, 3) assert.Contains(t, n, "UN") - assert.Equal(t, 1001, n["UN"]) + assert.Equal(t, 101, n["UN"]) assert.Contains(t, n, "DEUX") - assert.Equal(t, 1002, n["DEUX"]) + assert.Equal(t, 102, n["DEUX"]) assert.Contains(t, n, "TROIS") - assert.Equal(t, 1003, n["TROIS"]) + assert.Equal(t, 103, n["TROIS"]) } } diff --git a/services/groupware/pkg/groupware/suppliers_test.go b/services/groupware/pkg/groupware/suppliers_test.go index 4b27e547c5..9972314585 100644 --- a/services/groupware/pkg/groupware/suppliers_test.go +++ b/services/groupware/pkg/groupware/suppliers_test.go @@ -175,7 +175,7 @@ func TestSquery(t *testing.T) { } require.Equal(jmap.IncapableOfChangeCalculation, res.Payload.CanCalculateChanges) require.Nil(res.Payload.Limit) - require.Equal(uint(0), *res.Payload.Position) + require.Nil(res.Payload.Position) { m, err := unnext(n) require.NoError(err) @@ -197,7 +197,7 @@ func TestSquery(t *testing.T) { } require.Equal(jmap.IncapableOfChangeCalculation, res.Payload.CanCalculateChanges) require.Equal(uint(4), *res.Payload.Limit) - require.Equal(uint(0), *res.Payload.Position) + require.Nil(res.Payload.Position) { m, err := unnext(n) require.NoError(err) @@ -210,9 +210,9 @@ func TestSquery(t *testing.T) { require.Equal(uint(7), *res.Payload.Total) require.Len(res.Payload.Results, 3) { - require.Equal("fluffy", res.Payload.Results[4].name) - require.Equal("mitzi", res.Payload.Results[5].name) - require.Equal("rambo", res.Payload.Results[6].name) + require.Equal("fluffy", res.Payload.Results[0].name) + require.Equal("mitzi", res.Payload.Results[1].name) + require.Equal("rambo", res.Payload.Results[2].name) } } }