diff --git a/pkg/proto/v0/settings.pb.web.go b/pkg/proto/v0/settings.pb.web.go index f5410c2fe..813e7acd6 100644 --- a/pkg/proto/v0/settings.pb.web.go +++ b/pkg/proto/v0/settings.pb.web.go @@ -77,10 +77,11 @@ func (h *webBundleServiceHandler) ListSettingsBundles(w http.ResponseWriter, r * resp := &ListSettingsBundlesResponse{} - //if err := json.NewDecoder(r.Body).Decode(&req); err != nil { - // http.Error(w, err.Error(), http.StatusPreconditionFailed) - // return - //} + // TODO no need to parse any body on a get request. This code shoud be removed fro GET endpoints + // if err := json.NewDecoder(r.Body).Decode(&req); err != nil { + // http.Error(w, err.Error(), http.StatusPreconditionFailed) + // return + // } if err := h.h.ListSettingsBundles( context.Background(), diff --git a/pkg/service/v0/instrument.go b/pkg/service/v0/instrument.go index 10bbf0a22..99025513c 100644 --- a/pkg/service/v0/instrument.go +++ b/pkg/service/v0/instrument.go @@ -6,7 +6,10 @@ import ( // NewInstrument returns a service that instruments metrics. func NewInstrument(next Service, metrics *metrics.Metrics) Service { - return Service{} + return Service{ + manager: next.manager, + config: next.config, + } } type instrument struct { diff --git a/pkg/service/v0/logging.go b/pkg/service/v0/logging.go index 42c9b9722..c31d7bffc 100644 --- a/pkg/service/v0/logging.go +++ b/pkg/service/v0/logging.go @@ -6,7 +6,10 @@ import ( // NewLogging returns a service that logs messages. func NewLogging(next Service, logger log.Logger) Service { - return Service{} + return Service{ + manager: next.manager, + config: next.config, + } } type logging struct { diff --git a/pkg/service/v0/service.go b/pkg/service/v0/service.go index 2ab5fcf6d..f8fa95438 100644 --- a/pkg/service/v0/service.go +++ b/pkg/service/v0/service.go @@ -2,6 +2,7 @@ package svc import ( "context" + "github.com/owncloud/ocis-settings/pkg/settings" store "github.com/owncloud/ocis-settings/pkg/store/filesystem" diff --git a/pkg/service/v0/tracing.go b/pkg/service/v0/tracing.go index 434296fd3..0a39d51ac 100644 --- a/pkg/service/v0/tracing.go +++ b/pkg/service/v0/tracing.go @@ -2,7 +2,10 @@ package svc // NewTracing returns a service that instruments traces. func NewTracing(next Service) Service { - return Service{} + return Service{ + manager: next.manager, + config: next.config, + } } type tracing struct {